Skip to content

[WRONG BRANCH] fix(models): keep Free only bulk enable target-limited - #487

Draft
luvs01 wants to merge 1 commit into
mainfrom
codex/fix-bulk-action-scope-for-free-only
Draft

[WRONG BRANCH] fix(models): keep Free only bulk enable target-limited#487
luvs01 wants to merge 1 commit into
mainfrom
codex/fix-bulk-action-scope-for-free-only

Conversation

@luvs01

@luvs01 luvs01 commented Sep 12, 2026

Copy link
Copy Markdown
Owner

Motivation

  • The Free-only UI narrowed the visible list and counts to a scoped set but still sent a provider-scoped enable request, which could enable every model in that provider instead of only the filtered free models.

Description

  • When Free only is active, change the bulk action to send a models-scoped request instead of provider, preserving provider-scoped semantics when the list is not narrowed by Free only.
  • Apply the conditional scope in gui/src/pages/Models.tsx: use freeOnlyActive ? "models" : "provider" for applyVisibility calls.
  • Strengthen the regression test tests/gui/models-free-filter.test.ts to assert the conditional scope is present along with the existing target list assertions.

Testing

  • Ran bun test tests/gui/models-free-filter.test.ts and it passed (15 tests, 0 fail).
  • Ran bun run typecheck and it passed.
  • Ran the GUI test suite with cd gui && bun test tests and it passed locally (1,954 tests passed).
  • Ran cd gui && bun run build and the production build succeeded.
  • The repository-wide bun run test completed but includes environment-only/container-known failures unrelated to this change; focused GUI tests and typecheck/lint/build for the modified UI passed.

Codex Task

@coderabbitai

coderabbitai Bot commented Sep 12, 2026

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Advanced

Run ID: a4d42bdb-8223-4004-853e-a75acab7ed37


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 12, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-12T01:33:26.083500Z bbcc164 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@github-actions

Copy link
Copy Markdown

Deterministic PR hygiene checks passed.

@github-actions github-actions Bot added the bug Something isn't working label Sep 12, 2026
@github-actions github-actions Bot changed the title fix(models): keep Free only bulk enable target-limited [WRONG BRANCH] fix(models): keep Free only bulk enable target-limited Sep 12, 2026
@github-actions

Copy link
Copy Markdown

⏳ DRAFT

  • wrong target branch (main); retarget to dev. UI screenshot required.

What to do

  • Retarget this PR to dev — all contributions go to dev.
  • Add a screenshot of the UI change to the PR description.

Its title has been prefixed with [WRONG BRANCH].
This pull request is being kept as a draft automatically. Once every issue above is resolved, it will be marked ready for review again.

@github-actions
github-actions Bot marked this pull request as draft September 12, 2026 01:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

aardvark bug Something isn't working codex

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant