[WRONG BRANCH] fix(models): keep Free only bulk enable target-limited - #487
[WRONG BRANCH] fix(models): keep Free only bulk enable target-limited#487luvs01 wants to merge 1 commit into
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
✅ Deterministic PR hygiene checks passed. |
⏳ DRAFT
What to do
Its title has been prefixed with |
Motivation
scopedset but still sent a provider-scoped enable request, which could enable every model in that provider instead of only the filtered free models.Description
models-scoped request instead ofprovider, preserving provider-scoped semantics when the list is not narrowed by Free only.gui/src/pages/Models.tsx: usefreeOnlyActive ? "models" : "provider"forapplyVisibilitycalls.tests/gui/models-free-filter.test.tsto assert the conditional scope is present along with the existing target list assertions.Testing
bun test tests/gui/models-free-filter.test.tsand it passed (15 tests, 0 fail).bun run typecheckand it passed.cd gui && bun test testsand it passed locally (1,954 tests passed).cd gui && bun run buildand the production build succeeded.bun run testcompleted but includes environment-only/container-known failures unrelated to this change; focused GUI tests and typecheck/lint/build for the modified UI passed.Codex Task