[WRONG BRANCH] docs(cli): clarify platform-specific service repair behavior - #490
[WRONG BRANCH] docs(cli): clarify platform-specific service repair behavior#490luvs01 wants to merge 1 commit into
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
✅ Deterministic PR hygiene checks passed. |
github-actions
Bot
added
the
documentation
⏳ DRAFT
What to do
Its title has been prefixed with |
github-actions
Bot
changed the title
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d465f85752
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| | `repair` | Refresh an installed service in place. On macOS, the manager is reloaded only when something changed, so a healthy, unchanged job keeps running and the repair is not an outage. On Linux and Windows, the service is restarted; a healthy Windows scheduler definition is reused, while a stale definition may be re-registered and require elevation. | | ||
| | `restart` | The same refresh and a guaranteed restart on every platform. On macOS an unchanged, already-loaded job is kickstarted in place. Not an alias of `repair`. | |
There was a problem hiding this comment.
This platform-specific correction was applied only to English and Korean, while the French, Japanese, Russian, Turkish, Simplified Chinese, and Traditional Chinese lifecycle tables still state that repair always restarts the service and that restart is its alias. On macOS, readers of those pages can therefore run repair after an upgrade expecting a restart and leave the old process serving; update the corresponding translated tables and version-skew guidance to match the new canonical behavior.
AGENTS.md reference: docs-site/AGENTS.md:L7-L10
Useful? React with 👍 / 👎.
1 participant
Motivation
ocx service repairperforms a no-op reload on all platforms, but the implementation only avoids a restart on macOS; Linux and Windows still restart the service.repairexpecting no interruption on Linux/Windows and experience an unexpected restart.Description
docs-site/src/content/docs/reference/cli/lifecycle.mdto scope the no-oprepairbehavior to macOS, state that Linux and Windows restart the service, and make the version-skew advice macOS-specific.docs-site/src/content/docs/ko/reference/cli/lifecycle.md.src/were modified; this change is documentation-only and keeps Windows re-registration behavior described as conditional.Testing
cd docs-site && bun install --frozen-lockfile && bun run build, which completed successfully and produced 425 pages.bun run privacy:scan, which passed.git diff --checkas a validation step to ensure no trailing whitespace or diff-check issues; it reported clean results.Codex Task