fix(overlay): correct padding, ANSI clipping, and Unicode rendering - #72
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Description
Fixes overlay rendering issues found while adding test coverage in #71. The fixes address ignored bottom padding, incorrect character alignment, duplicated ANSI escape bytes, and custom whitespace rendering.
Changes Made
Testing
filters,output, etc...Checklist
Greptile Summary
This PR corrects bottom-right overlay placement and strengthens ANSI-aware clipping, Unicode cell-width handling, and custom whitespace rendering. Focused rendering checks confirmed the updated behavior across styled wide glyphs, combining characters, and zero-width whitespace patterns.
Confidence Score: 5/5
Safe to merge: no blocking issues were identified in the changed overlay behavior.
The completed focused rendering checks passed on the PR revision, and no actionable issues remain.
Files Needing Attention: None.
What T-Rex did
Reviews (1): Last reviewed commit: "fix(overlay): preserve padding and unico..." | Re-trigger Greptile