alacconvert does not handle 8-bit wav

[macosforgebot]

justin.ruggles@… originally submitted this as ticket:12

• Version: 1.0

---

Instead of rejecting it as unsupported, the encoder seems to try to encode it, but goes into an infinite loop.

[macosforgebot]

contact@… originally submitted this as comment:1:⁠ticket:12

---

I've made changes to check for supported WAV PCM bit depth (i.e., reject anything that's not 16- or 24-bit).

It's my first time submitting changes to MacOSforge — are there any guidelines regarding code review before committing, &cet.? Thanks!

[macosforgebot]

contact@… originally submitted this as attachment:patch.main.cpp:⁠ticket:12

• Attachment patch.main.cpp (1.4 KB) added

---

Patch for convert-utility/main.cpp

[AngeloStavrow]

Should I fork and re-submit the patch as a pull request?

EDIT: Ah, wait. I'm only patching the convert utility, not the encoder itself. Will fix.