Conversation
The preserve-line-breaks allowlist landed 2026-09-14, one day before ZCode became a chat agent family, so ZCode was never added to it. The ZCode TUI paints every soft-break newline as its own row, while the chat collapsed those replies into one flowing paragraph with the glyph-list indentation scattered mid-sentence. Add the zcode family to sessionChatPreservesAgentLineBreaks and refresh the CDXC comments (the Claude/Codex/Grok Build/Cursor exclusion from 2026-09-14 is unchanged).
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 4 included reviews per hour; 3 remain after this review. 📝 WalkthroughWalkthroughThe chat presentation provider now preserves single newlines in ZCode assistant replies. The related documentation identifies ZCode as a preserving agent family and records unchanged OMP terminal behavior. ChangesZCode line-break handling
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~5 minutes Change: Bug fix Suggested reviewers: Merge Risk: ⚪ Minimal · up to No actionable correctness or availability risk is established for this focused rendering change. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Problem: ZCode replies render differently in the Ghostex chat view than in the ZCode terminal. The TUI paints every soft-break newline as its own row (glyph status lines, emoji lists, em-space indentation), but the chat view collapsed the same message into one flowing paragraph, scattering the indentation mid-sentence.
Root cause:
sessionChatPreservesAgentLineBreaksis an opt-in allowlist per agent family. The feature landed in 6cf849b (2026-09-14) listing Pi, Hermes, and Antigravity; ZCode became a chat agent family one day later (94f62db) and was never added.remarkSessionChatHardBreakstherefore never fires for ZCode transcripts.Fix: add
zcodeto the family check, and refresh theCDXC:SessionChatWHY/DECISION comments. The 2026-09-14 decision to leave Claude, Codex, Grok Build, and Cursor unchanged is untouched — ZCode simply was not covered by it.Verification: root
tsc --noEmitpasses (the only errors are pre-existing@/apps/web/...resolutions from an uninitialized submodule in my worktree, reproducible without this change). Rendering behavior for ZCode now matches the existing Pi/Hermes/Antigravity treatment: one rendered row per source line, paragraph breaks on blank lines.Note
Preserve single newlines for ZCode replies in
sessionChatPreservesAgentLineBreaksExtends the agent-family predicate in session-chat-presentation-provider.tsx to return
truewhen the transcript family iszcode, so ZCode assistant replies keep single newlines. Updates theSessionChatAgentLineBreaksContextcomment to document ZCode's one-row-per-line TUI behavior.Macroscope summarized d3f8bdb.
Summary by CodeRabbit