Skip to content

Attempts a more portable rgba extraction #357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
freost wants to merge 3 commits into from
Closed

Attempts a more portable rgba extraction #357

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c057279
Attempts a more portable rgba extraction
freost Aug 5, 2026
f58b66d
Try getColorValue for alpha
freost Aug 5, 2026
ffcfde5
Update tests.yml
freost Aug 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .github/workflows/tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,10 @@ jobs:
steps:
- name: "Checkout code"
uses: "actions/checkout@v7"
- name: "Pre-install system image libraries"
run: |
sudo apt-get update
sudo apt-get install -y libpng-dev libjpeg-dev libwebp-dev imagemagick
- name: "Setup PHP"
uses: "shivammathur/setup-php@v2"
with:
Expand Down
9 changes: 7 additions & 2 deletions src/mako/pixel/image/inspectors/imagemagick/ColorAt.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,8 +47,13 @@ public function inspect(object &$imageResource): mixed

$pixel = $imageResource->getImagePixelColor($this->pixel->x, $this->pixel->y);

$rgba = $pixel->getColor(2); // 2 = RGBA normalized to 0-255
$color = $pixel->getColor(1);

return new Color($rgba['r'], $rgba['g'], $rgba['b'], $rgba['a']);
$r = (int) round($color['r'] * 255);
$g = (int) round($color['g'] * 255);
$b = (int) round($color['b'] * 255);
$a = (int) round($pixel->getColorValue(Imagick::COLOR_ALPHA) * 255);

return new Color($r, $g, $b, $a);
}
}
11 changes: 8 additions & 3 deletions src/mako/pixel/image/inspectors/imagemagick/TopColors.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,13 +53,18 @@ public function inspect(object &$imageResource): mixed
break;
}

$rgba = $pixel->getColor(2); // 2 = RGBA normalized to 0-255
$color = $pixel->getColor(1);

if ($hasAlphaChannel && $this->ignoreTransparent && $rgba['a'] === 0) {
$r = (int) round($color['r'] * 255);
$g = (int) round($color['g'] * 255);
$b = (int) round($color['b'] * 255);
$a = (int) round($pixel->getColorValue(Imagick::COLOR_ALPHA) * 255);

if ($hasAlphaChannel && $this->ignoreTransparent && $a === 0) {
continue;
}

$colors[] = new Color($rgba['r'], $rgba['g'], $rgba['b'], $rgba['a']);
$colors[] = new Color($r, $g, $b, $a);
}

return $colors;
Expand Down
3 changes: 2 additions & 1 deletion tests/unit/pixel/image/operations/imagemagick/ReplaceColorTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,14 +36,15 @@ public function testReplaceColors(): void

$image->apply(new ReplaceColor(
Color::fromHex('#0376BB'),
new Color(0, 0, 0)
new Color(0, 0, 0, 127)
));

$colors = $image->inspect(new TopColors);

$this->assertCount(3, $colors);

$this->assertSame('#000000', $colors[0]->toHexString());
$this->assertSame('#0000007F', $colors[0]->toHexaString());
$this->assertSame('#B51700', $colors[1]->toHexString());
$this->assertSame('#047101', $colors[2]->toHexString());
}
Expand Down
Loading