Enhance device capabilities and constraints management by spulkit138 · Pull Request #381 · margo/sandbox

spulkit138 · 2026-08-21T13:16:11Z

Enhance device capabilities and constraints management

Summary

This PR introduces a consolidated system for managing device capabilities and runtime constraints. Implementation of (Device Runtime SUP)[https://github.com/margo/specification-enhancements/blob/main/proposals/sup_device_specific_runtime_affinity_matching.md]
Adds core logic to define, validate, store, and enforce capability definitions and constraint rules across devices.
Includes implementation, tests, and documentation updates to support the new capabilities/constraints workflow.

Key changes

New modules and/or services for:
- Device capability model: canonical representation of device capabilities and metadata.
- Constraints manager/engine: declarative constraint definitions, evaluation, and enforcement.
- Validation and registration hooks: capability/constraint validation at device onboarding and updates.
Persistence and migrations:
- Adds persistency support for capability definitions and constraints (DB schema and/or storage updates included).
Tests:
- Unit tests and integration tests covering capability validation, constraint evaluation, edge cases and error handling.
Docs:
- Developer docs and usage examples for defining capabilities and constraints, and running migration/scripts.

Checklist

Implementation of device capability model
Constraints manager/engine implemented
Unit + integration tests added
Docs / usage examples added

Signed-off-by: Pulkit Sharma <pulkit.d.sharma@capgemini.com>

…s and custom runtime Signed-off-by: Pulkit Sharma <pulkit.d.sharma@capgemini.com>

…ibrary Signed-off-by: Pulkit Sharma <pulkit.d.sharma@capgemini.com>

…pp pkg id Signed-off-by: Pulkit Sharma <pulkit.d.sharma@capgemini.com>

…eligible devices Signed-off-by: Pulkit Sharma <pulkit.d.sharma@capgemini.com>

…g app Signed-off-by: Pulkit Sharma <pulkit.d.sharma@capgemini.com>

Signed-off-by: Pulkit Sharma <pulkit.d.sharma@capgemini.com>

…nerated Signed-off-by: Pulkit Sharma <pulkit.d.sharma@capgemini.com>

Signed-off-by: Pulkit Sharma <pulkit.d.sharma@capgemini.com>

…requirements Signed-off-by: Pulkit Sharma <pulkit.d.sharma@capgemini.com>

…ased on label matching Signed-off-by: Pulkit Sharma <pulkit.d.sharma@capgemini.com>

Signed-off-by: Pulkit Sharma <pulkit.d.sharma@capgemini.com>

…t library Signed-off-by: Pulkit Sharma <pulkit.d.sharma@capgemini.com>

Signed-off-by: Pulkit Sharma <pulkit.d.sharma@capgemini.com>

…e deploying app Signed-off-by: Pulkit Sharma <pulkit.d.sharma@capgemini.com>

…ment Signed-off-by: Pulkit Sharma <pulkit.d.sharma@capgemini.com>

Signed-off-by: Pulkit Sharma <pulkit.d.sharma@capgemini.com>

vireshnavalli · 2026-08-25T08:34:55Z

 - **Workload management** (`workloads/`) - Helm and Docker Compose clients
 - **Archive** (`archive/`) - Unpacking or packing archives(tar.gz) etc..
 - **Pointer operations** (`pointers/`) - Some helper functions to deep clone, safely get pointer to temp variables etc...
+- **Device Constraint Selector Engine** (`constraints/`) - Reusable device eligibility checking library for the checks defined in [Device Runtime Affinity SUP](https://github.com/margo/specification-enhancements/blob/main/proposals/sup_device_specific_runtime_affinity_matching.md)


Need to change this path once it is merged to completed folder or better to provide specification PR path as there might be some changes post specification-enhancement PR approval.

I checked in specification PR , this exact content is not there, hence I would say we can change path once it is moved to completed folder.

vireshnavalli · 2026-08-25T09:03:48Z


 **Tools:**
 - **Setup script** (`wfm.sh`, `device-agent.sh`) - Automated environment setup (Harbor, device's Workload Fleet Management Client, Symphony etc.)
+- **Label Generator Script** (`create-device-labels.sh`) - This script helps users generate labels for a device as per the guidelines defined here: [Device Runtime Affinity SUP](https://github.com/margo/specification-enhancements/blob/main/proposals/sup_device_specific_runtime_affinity_matching.md)


here are refer the specification PR because specification-enhancement moved to completed folder from proposal folder once spec PR is approved/merged to pre-draft

I checked in margo/specification#203 , this exact content is not there, hence I would say we can change path once it is moved to completed folder, as this PR will be merged in main when specification PR will be merged.

vireshnavalli · 2026-08-25T09:08:11Z

          in: query
          schema: { type: string }
          description: Token for pagination
+        - name: appPackageId


what is the purpose of this additional parameter, where this input come from?

As discussed, WFM CLI would show "eligible or not eligible" while selecting device for a particular deployment. For that eligibility check, List Device needs an optional parameter "application package Id" in order to get application device constraints for that particular application package. More information is present in description of this PR : #374

vireshnavalli · 2026-08-25T09:11:48Z

            oneOf:
            - $ref: '#/components/schemas/HelmApplicationDeploymentProfileComponent'
            - $ref: '#/components/schemas/ComposeApplicationDeploymentProfileComponent'
+            - $ref: '#/components/schemas/CustomApplicationDeploymentProfileComponent'


I think we have discussed this already, as you have one more profile component (custom). shall we merge all as single for better clarity? what is your thought?

I pointed out this previously that does non-standard API need to change as well in compose oci changes. My point was, for parts which are same in standard & non-standard, we should keep standard as single source of truth. Hence change here should be done and should be same to what is present in standard. Custom Runtime PR introduces a custom runtime apart from helm/compose. Hence this change was added.

If we align to change it, my suggestion would be to either change it as a separate PR and then we pull changes in this to align it; OR after merging this a separate PR should be raised for that change. That ways, we can keep these two things separate.

vireshnavalli · 2026-08-25T09:18:32Z

+    "labels": {
+        "northstarida.com/hypervisor": "hyper-v",
+        "northstarida.com/wasm.runtime": [
+            "wamr"
+        ],
+        "northstarida.com/wasm.package.format": [
+            ".wasm",
+            ".aot"


we have single static capability file for both helm and compose and we update supportedDeploymentTypes (any other attributes) during setup

Introducing these labels are not necessary from helm and compose right?

Labels are totally optional. Here, they are just placeholders for reference. They are not used while deployment. In installation scripts, I have provided a different way to add labels while installing WFM Client. And if labels are not provided at installation time, these placeholder labels are removed automatically.

Keeping it here just because if someone wants to deploy as a binary, they will know how labels can be added, and they can modify/remove as required.

vireshnavalli · 2026-08-25T09:21:05Z

 		// Only deploy if not already installed
 		if currentState != sbi.DeploymentStatusManifestStatusStateInstalled {
 			dm.log.Debugw("deploying pending deployment", "deploymentId", deploymentId)
+			// TODO: Check if device is eligible or not, if not, set it to failed state even before deployment


is checking device eligibility planned later? IMO, WFM will filter device is eligible or not.?

I forgot to remove this TODO comment. I have removed it now.

As per discussion, WFM will just show whether a device is eligible or not. Selection of a particular device still remains with the user. However, on Device agent side, if a particular application is ineligible, it is put in FAILED mode without even deploying it.

Signed-off-by: Pulkit Sharma <pulkit.d.sharma@capgemini.com>

spulkit138 added this to the SPRINT_22_PR3 milestone Aug 21, 2026

spulkit138 self-assigned this Aug 21, 2026

spulkit138 requested review from nitparihar, rishabhrai9616, sanjujunnuthula, singhmj-1 and vireshnavalli as code owners August 21, 2026 13:16

spulkit138 added enhancement New feature or request SPRINT_22 SPRINT_22 labels Aug 21, 2026

spulkit138 linked an issue Aug 21, 2026 that may be closed by this pull request

[TASK: ] Integrate Device Selector in WFM & WFM Client #375

Open

4 tasks

spulkit138 mentioned this pull request Aug 21, 2026

Enhance device capabilities and filtering by appPkgId margo/symphony#66

Merged

spulkit138 added 19 commits August 24, 2026 04:55

feat(device-agent): generated code from spec and minor compilation fix

8726aac

Signed-off-by: Pulkit Sharma <pulkit.d.sharma@capgemini.com>

feat(device-agent): added support for device labels

25839d1

Signed-off-by: Pulkit Sharma <pulkit.d.sharma@capgemini.com>

feat(docs): updated docs, added manual approach of adding labels

2d52e58

Signed-off-by: Pulkit Sharma <pulkit.d.sharma@capgemini.com>

feat(scripts): added cleanup process if labels are missing

e0eba94

Signed-off-by: Pulkit Sharma <pulkit.d.sharma@capgemini.com>

fix(scripts): fixed location of intermediate label file

9481c3e

Signed-off-by: Pulkit Sharma <pulkit.d.sharma@capgemini.com>

fix(scripts): removed stray lines

7ec4bca

Signed-off-by: Pulkit Sharma <pulkit.d.sharma@capgemini.com>

feat(non-standard): added and generated changes for device constraint…

4f09470

…s and custom runtime Signed-off-by: Pulkit Sharma <pulkit.d.sharma@capgemini.com>

feat(shared-lib): added boilerplate code for eligible device finder l…

ab68b67

…ibrary Signed-off-by: Pulkit Sharma <pulkit.d.sharma@capgemini.com>

feat(non-standard): added flag for listing devices eligible against a…

149b007

…pp pkg id Signed-off-by: Pulkit Sharma <pulkit.d.sharma@capgemini.com>

feat(wfm-cli): adapted list device client for app pkg id for getting …

19fe54b

…eligible devices Signed-off-by: Pulkit Sharma <pulkit.d.sharma@capgemini.com>

feat(scripts): added flag for getting eligible devices while deployin…

76c6838

…g app Signed-off-by: Pulkit Sharma <pulkit.d.sharma@capgemini.com>

feat(artefacts): added device constraints to application packages

104ad66

Signed-off-by: Pulkit Sharma <pulkit.d.sharma@capgemini.com>

fix(scripts): corrected flag for appPkgId while listing devices

989358c

Signed-off-by: Pulkit Sharma <pulkit.d.sharma@capgemini.com>

fix(non-standard): corrected model yaml for device constraints and ge…

7084af6

…nerated Signed-off-by: Pulkit Sharma <pulkit.d.sharma@capgemini.com>

feat(shared-lib): added helper data structure for set

6d91abc

Signed-off-by: Pulkit Sharma <pulkit.d.sharma@capgemini.com>

feat(shared-lib): added logic to check for device compute requirements

94a7cea

Signed-off-by: Pulkit Sharma <pulkit.d.sharma@capgemini.com>

feat(shared-lib): refactored logic and tests to check device compute …

dcf7f53

…requirements Signed-off-by: Pulkit Sharma <pulkit.d.sharma@capgemini.com>

feat(shared-lib): added logic and tests to check device eligibility b…

524be5d

…ased on label matching Signed-off-by: Pulkit Sharma <pulkit.d.sharma@capgemini.com>

feat(shared-lib): integrated label matching in device selector

52b0ec6

Signed-off-by: Pulkit Sharma <pulkit.d.sharma@capgemini.com>

spulkit138 added 20 commits August 24, 2026 05:05

feat(shared-lib): updated directory structure for constraints library

a6eaf0f

Signed-off-by: Pulkit Sharma <pulkit.d.sharma@capgemini.com>

chore(shared-lib): added mini parser for IEC units comparison

93374b6

Signed-off-by: Pulkit Sharma <pulkit.d.sharma@capgemini.com>

chore(shared-lib): replaced k8s quantity parser with internal parser

adbf1a6

Signed-off-by: Pulkit Sharma <pulkit.d.sharma@capgemini.com>

chore(shared-lib): added readmes for usage instructions for constrain…

078559f

…t library Signed-off-by: Pulkit Sharma <pulkit.d.sharma@capgemini.com>

chore(shared-lib): ran golangci lint on constraints library

bb22c1c

Signed-off-by: Pulkit Sharma <pulkit.d.sharma@capgemini.com>

chore(shared-lib): removed unnecesary files

a46e746

Signed-off-by: Pulkit Sharma <pulkit.d.sharma@capgemini.com>

chore(shared-lib): corrected formatting of quantity package

53693fb

Signed-off-by: Pulkit Sharma <pulkit.d.sharma@capgemini.com>

chore(shared-lib): resolved issues flagged by ci linter

89ff76f

Signed-off-by: Pulkit Sharma <pulkit.d.sharma@capgemini.com>

fix(shared-lib): added fix for failing testcases

8595235

Signed-off-by: Pulkit Sharma <pulkit.d.sharma@capgemini.com>

fix(non-standard): added missing deployment profile type custom

d52d5c3

Signed-off-by: Pulkit Sharma <pulkit.d.sharma@capgemini.com>

feat(device-agent): added logic to check for device capabilities whil…

d22feb1

…e deploying app Signed-off-by: Pulkit Sharma <pulkit.d.sharma@capgemini.com>

fix(non-standard): removed required resources from application deploy…

931c6e3

…ment Signed-off-by: Pulkit Sharma <pulkit.d.sharma@capgemini.com>

chore(artefacts): updated margo app definition with device constraints

1ec487e

Signed-off-by: Pulkit Sharma <pulkit.d.sharma@capgemini.com>

fix(config): corrected capability cpu resource key

1a2059a

Signed-off-by: Pulkit Sharma <pulkit.d.sharma@capgemini.com>

fix(config): corrected capability mem and storage resource values

acf52f8

Signed-off-by: Pulkit Sharma <pulkit.d.sharma@capgemini.com>

chore(docs): updated documentation

49adb3f

Signed-off-by: Pulkit Sharma <pulkit.d.sharma@capgemini.com>

fix(artefacts): removed trailing newlines

fe1f9a9

Signed-off-by: Pulkit Sharma <pulkit.d.sharma@capgemini.com>

fix(artefacts): removed trailing whitespace and added newline at the end

a6ba504

Signed-off-by: Pulkit Sharma <pulkit.d.sharma@capgemini.com>

fix(shared-lib): quantity parser now tolerates space bw scalar and unit

937dcf5

Signed-off-by: Pulkit Sharma <pulkit.d.sharma@capgemini.com>

fix(misc): regenerated standard and non standard spec

069e442

Signed-off-by: Pulkit Sharma <pulkit.d.sharma@capgemini.com>

spulkit138 force-pushed the feature/device-constraints branch from 0bf620d to 069e442 Compare August 24, 2026 05:28

vireshnavalli reviewed Aug 25, 2026

View reviewed changes

chore(device-agent): removed stale todo comment

733964b

Signed-off-by: Pulkit Sharma <pulkit.d.sharma@capgemini.com>

vireshnavalli added SPRINT_23 SPRINT_23 and removed SPRINT_22 SPRINT_22 labels Sep 7, 2026

Navigation Menu

Uh oh!

Enhance device capabilities and constraints management - #381

Enhance device capabilities and constraints management#381
spulkit138 wants to merge 44 commits into
developmentfrom
feature/device-constraints

spulkit138 commented Aug 21, 2026 •

edited

Loading

Uh oh!

vireshnavalli Aug 25, 2026

Uh oh!

spulkit138 Aug 25, 2026

Uh oh!

vireshnavalli Aug 25, 2026

Uh oh!

spulkit138 Aug 25, 2026 •

edited

Loading

Uh oh!

vireshnavalli Aug 25, 2026

Uh oh!

spulkit138 Aug 25, 2026

Uh oh!

vireshnavalli Aug 25, 2026

Uh oh!

spulkit138 Aug 25, 2026

Uh oh!

vireshnavalli Aug 25, 2026

Uh oh!

spulkit138 Aug 25, 2026

Uh oh!

vireshnavalli Aug 25, 2026

Uh oh!

spulkit138 Aug 25, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

spulkit138 commented Aug 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Enhance device capabilities and constraints management

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

spulkit138 Aug 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

spulkit138 commented Aug 21, 2026 •

edited

Loading

spulkit138 Aug 25, 2026 •

edited

Loading