fix(cli): change the command for extracting the deployment type - #388
Open
nhat-14 wants to merge 1 commit into
Open
fix(cli): change the command for extracting the deployment type#388nhat-14 wants to merge 1 commit into
nhat-14 wants to merge 1 commit into
Conversation
nhat-14
requested review from
nitparihar,
rishabhrai9616 and
sanjujunnuthula
as code owners
August 28, 2026 09:06
…pplication description Signed-off-by: Nhat Luong <Luong.Ducnhat@dc.MitsubishiElectric.co.jp>
nhat-14
force-pushed
the
fix/fix-not-detect-deployment-type
branch
from
August 28, 2026 09:12
135fa28 to
ec5b44e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix deployment type detection in
scripts/easy-cli/cli-yaml-gen.sh.My deployment of a compose application was failed as the script couldn't extract the deployment type from the
margo.yaml. Thespecis no longer a top-level attribute, anddeploymentProfiles(plural) is the correct field for deployment information.deploymentProfilesis also a list, so the existingspec:/deploymentProfile:parsing could not detect the deployment type.Motivation
Update the script to follow application description structure and correctly detect the deployment type.
Testing
Tested with a simple
margo.org/v1-alpha1Compose application description containing:Result:
Checklist