`bs_btn` with `link` creates `type=button` anchor tag

[fiedl]

Context

This concerns the button component:
https://github.com/matestack/matestack-ui-bootstrap/blob/main/lib/matestack/ui/bootstrap/components/button.rb

Scenario

Specifying a link for a bs_btn:

bs_btn "wählen", link: { path: dashboard_path }

Observed behaviour

A <a type="button" class="btn btn-primary"> tag is generated, which is not styled as expected by bootstrap.

Expected behaviour

To be styled correctly by bootstrap, the tag should be:

• <button type="button" class="btn btn-primary">, or:
• <a class="btn btn-primary"> (without the type)

Workaround

Overwrite the type attribute:

bs_btn "wählen", type: "", link: { path: dashboard_path }

Browsers

I have observed this in Safari. It looks correct, however, in Chrome.

[aaron-contreras]

Hey @fiedl , I see this has been open for a while. I've actually experienced this exact behavior while working on a client project and didn't realize there was an open issue for it here. I'll work on a fix for it. Thanks for documenting the root cause, that helps a lot and makes it quite cookie-cutter for me :)