Prevent mjolnir self-kick - #688
Open
crime-think wants to merge 5 commits into
Open
crime-think wants to merge 5 commits into
crime-think wants to merge 5 commits into
Conversation
crime-think
marked this pull request as ready for review
July 14, 2026 14:12
This reverts commit 3ab1a7d.
crime-think
marked this pull request as draft
July 14, 2026 15:21
crime-think
marked this pull request as ready for review
July 14, 2026 15:47
Contributor
|
@crime-think thanks for doing this! Would you be willing to add a quick test in |
H-Shay
reviewed
Jul 24, 2026
| @@ -0,0 +1,57 @@ | |||
| /* | |||
| Copyright 2024 The Matrix.org Foundation C.I.C. | |||
|
|
|||
H-Shay
reviewed
Jul 24, 2026
| await mod.setUserPowerLevel(botId, targetRoom, 100); | ||
|
|
||
| await mod.sendMessage(this.mjolnir.managementRoomId, { | ||
| msgtype: "m.text.", |
Contributor
There was a problem hiding this comment.
Suggested change
| msgtype: "m.text.", | |
| msgtype: "m.text", |
Contributor
|
@crime-think thanks for the test - I just noticed a few tiny nits. Also could you just add a section to the test demonstrating a successful kick of a non-bot user? Otherwise I think this is ready to go :) |
H-Shay
requested changes
Jul 24, 2026
H-Shay
reviewed
Jul 24, 2026
| }); | ||
| }); | ||
| await reply; | ||
|
|
Contributor
There was a problem hiding this comment.
Also it would be good to assert that the bot is still in the room in addition to verifying that the warning message fired.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix to issue #647