fix(android): time formatting uses AM/PM in French locale

[sebsto]

Fixes #86

Problem

Date.formatted(date: .omitted, time: .shortened) on Android doesn't propagate the app locale to java.text.DateFormat, so French users see AM/PM instead of 24h format in the "Diffusé à" line.

Fix

Replace with an explicit DateFormatter that sets Locale.current, guarded behind #if os(Android). iOS path unchanged.

Upstream

Opened skiptools/skip-foundation#128 — once fixed there, this workaround can be removed.

Also

Documents Android build pitfalls in SKIP_ARCHITECTURE.md steering (don't import Foundation alongside SwiftUI, preferredLocalizations unavailable on Android).

[Copilot]

Pull request overview

This PR fixes incorrect AM/PM time rendering for French users on Android by avoiding Date.formatted(date:time:) in the affected UI and using an explicit DateFormatter with Locale.current under #if os(Android). It also documents Android-specific build/locale pitfalls in the Skip architecture steering notes.

Changes:

• Replaced Date.formatted(date: .omitted, time: .shortened) usage in SongLabelView with a new shortTimeString(from:) helper that sets DateFormatter.locale = Locale.current on Android.
• Kept the iOS/macOS path unchanged by continuing to use Date.formatted(date:time:) on non-Android platforms.
• Added an “Android Build Pitfalls” section to SKIP_ARCHITECTURE.md, including notes about locale propagation and imports.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File	Description
Sources/Maxi80/Views/RadioPlayer/SongLabelView.swift	Adds an Android-specific time formatting workaround and routes UI strings through it.
.kiro/steering/SKIP_ARCHITECTURE.md	Documents Android Fuse-module pitfalls and the Date.formatted locale issue/workaround.

Suppressed comments (1)

Sources/Maxi80/Views/RadioPlayer/SongLabelView.swift:105

• The doc comment says the Android workaround derives locale from the app bundle’s preferred localization, but the implementation uses Locale.current (and preferredLocalizations is documented as unavailable on Android in SKIP_ARCHITECTURE.md). This mismatch is confusing—please align the comment with the actual behavior.

  /// On iOS, `Date.formatted(date:time:)` correctly picks up the device locale. On Android (native
  /// fuse mode), SkipFoundation's implementation doesn't propagate the locale to the underlying
  /// `java.text.DateFormat`, causing French users to see AM/PM. Work around this by using an explicit
  /// `DateFormatter` with the locale derived from the app bundle's preferred localization.
  /// See: https://github.com/skiptools/skip-foundation/issues/128

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.