chore(deps): react and @types/react 19.2.8 / 19.2.18 - #75
Merged
Merged
Conversation
Supersedes #55, which went CONFLICTING against main and did not respond to two @dependabot rebase requests. Same content as #55, with react-dom carried along so the runtime pair does not skew — #55 bumped react alone, which would have left react-dom at 19.2.5. Deliberately NOT React 19.3.0. `pnpm add react@^19.2.8` resolves to 19.3.0 today, and that minor costs 29 kB in the bundle: 19.2.8 dist/bundle.html 428.46 kB gzip 125.86 kB 19.3.0 dist/bundle.html 457.75 kB gzip 134.51 kB bundle.html is the primary deliverable and ships as a single offline file, so a ~7% size increase is a decision, not a side effect of a patch bump. The caret ranges here match what Dependabot proposed and the lockfile pins 19.2.8, which is exactly the shape #55 would have had. When Dependabot opens 19.3.0 on its own, that PR can be judged on its own merits with the size cost visible. tsc -b clean, 79/79 tests, build clean, lint unchanged. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersedes #55, which went
CONFLICTINGagainst main and didn't respond to two@dependabot rebaserequests.Same content, plus
react-domcarried along so the runtime pair doesn't skew — #55 bumpedreactalone, which would have leftreact-domat 19.2.5.Deliberately not React 19.3.0
pnpm add react@^19.2.8resolves to 19.3.0 today, and that minor is not free:bundle.htmlis the primary deliverable and ships as a single self-contained offline file, so +29 kB (~7%) is a decision, not a side effect of a patch bump.The caret ranges here match what Dependabot proposed and the lockfile pins 19.2.8 — structurally identical to what #55 would have been. When Dependabot opens 19.3.0 on its own, it can be judged on its merits with that size cost visible.
Verification
tsc -b --noEmitcleanpnpm buildclean at 428.46 kB (unchanged from main)pnpm lintunchanged — same 1 local-only error + 3 knownreact-hooks/refswarnings as mainClose #55 in favour of this.
🤖 Generated with Claude Code
Safe to merge: the updated runtime and type packages install reproducibly and the application checks, tests, and builds successfully.
What we checked:
Summary
@types/reactto 19.2.18.This change is safe to merge.
Reviews (1) · Last reviewed commit: "chore(deps): react and @types/react 19.2..."