[Fix]: Flaky test - does not include an alert if that alert is also the banner alert - #3444
Merged
Conversation
… was only using :rand(0-999) for ids, and the test was randomly selecting 5. I upped the range to 0-9,999,999 since real alerts are in the seven digits anyway. While this will not entirely eliminate the flakyness of this test, it will make it happen way less often (1:250 to 1:2,500,000 by my math)
thecristen
approved these changes
Aug 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope
Asana Ticket: 🛠️ Flaky test - does not include an alert if that alert is also the banner alert
Implementation
Found that there were ID collisions on the failing cases. The factory was only using :rand(0-999) for ids, and the test was randomly selecting 5. I upped the range to 0-9,999,999 since real alerts are in the seven digits anyway. While this will not entirely eliminate the flakyness of this test, it will make it happen way less often (1:250 to 1:2,500,000 by my math)
Added explanation and debug info for when the assertion eventually fails
Screenshots
N/A
How to test
mix test test/dotcom/alerts_test.exs --repeat-until-failure 500- Confirm the test always passes. This takes a little over a minute on my machine, you can alter the500to fit how patient you are.