Skip to content

non-standard-hisi_hip08: check the payload length before decoding #266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
agenticode wants to merge 1 commit into
base: master
Choose a base branch
from
Open

non-standard-hisi_hip08: check the payload length before decoding #266

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions events-arch-arm/non-standard-hisi_hip08.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -676,6 +676,11 @@ static int decode_hip08_oem_type1_error(struct ras_events *ras,
(struct hisi_oem_type1_err_sec *)event->error;
struct ras_stmt *stmt = hip08_oem_type1_event_db.stmt;

if (!event->error || event->length < sizeof(*err)) {
trace_seq_printf(s, "%s: truncated payload\n", __func__);
return -1;
}

if (ras->record_events)
WARN_ONCE(!stmt, ALL, LOG_WARNING,
"Can't insert into table %s: no statement\n",
Expand Down Expand Up @@ -842,6 +847,11 @@ static int decode_hip08_oem_type2_error(struct ras_events *ras,
(struct hisi_oem_type2_err_sec *)event->error;
struct ras_stmt *stmt = hip08_oem_type2_event_db.stmt;

if (!event->error || event->length < sizeof(*err)) {
trace_seq_printf(s, "%s: truncated payload\n", __func__);
return -1;
}

if (ras->record_events)
WARN_ONCE(!stmt, ALL, LOG_WARNING,
"Can't insert into table %s: no statement\n",
Expand Down Expand Up @@ -987,6 +997,11 @@ static int decode_hip08_pcie_local_error(struct ras_events *ras,
(struct hisi_pcie_local_err_sec *)event->error;
struct ras_stmt *stmt = hip08_pcie_local_event_db.stmt;

if (!event->error || event->length < sizeof(*err)) {
trace_seq_printf(s, "%s: truncated payload\n", __func__);
return -1;
}

if (ras->record_events)
WARN_ONCE(!stmt, ALL, LOG_WARNING,
"Can't insert into table %s: no statement\n",
Expand Down
Loading