feat(new): add --container-runtime flag (parity with mxcli init)#740
Open
kaspergff wants to merge 1 commit into
Open
feat(new): add --container-runtime flag (parity with mxcli init)#740kaspergff wants to merge 1 commit into
kaspergff wants to merge 1 commit into
Conversation
mxcli new always generated a Docker-based devcontainer because it called initCmd.Run() without forwarding the container runtime preference. This adds --container-runtime (docker|podman, default docker) to newCmd and sets initContainerRuntime before the init call so the generated .devcontainer/ reflects the user's choice. Closes mendixlabs#739 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mxcli newalways generated a Docker-based devcontainer because it calledinitCmd.Run()without forwarding the container runtime preference--container-runtime docker|podmanflag tomxcli new, matching the existing flag onmxcli initinitContainerRuntimebefore the internalinitcall so the generated.devcontainer/reflects the user's choiceTest plan
mxcli new --helpshows--container-runtimeflagmxcli new MyApp --version 11.12.0 --container-runtime podmangenerates.devcontainer/devcontainer.jsonwithMXCLI_CONTAINER_CLI=podmanandrunArgsmxcli new MyApp --version 11.12.0(default) generates Docker-based devcontainer as beforepodman buildon the generated Dockerfile succeedsCloses #739
🤖 Generated with Claude Code