Treat Stripe permission errors as invalid keys - #796
Merged
Merged
Conversation
Company payment settings crashed with 500 when Stripe returned 403 for Charge.list, instead of marking the key invalid. Co-authored-by: Cursor <cursoragent@cursor.com>
s3341458
approved these changes
Sep 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
is_valid_keynow treats empty keys, publishablepk_keys, and anystripe.error.StripeError(includingPermissionError) as invalid instead of letting the exception abort the company save.Charge.listno longer 500s;isStripeValidis set to false, or the existing 400 is returned if Stripe is already enabled.Test plan
pk_…) as the secret key and confirm the company save succeeds (or returns the existing 400 if Stripe is enabled), not a 500sk_test_/sk_live_key matching company test/live mode and confirmisStripeValidis truepython/tests/test_stripe_util.pyMade with Cursor
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.