Skip to content

refactor(scripts): extract transaction send helpers into transactions.ts - #491

Merged
metapileks merged 1 commit into
developfrom
pileks/proposal-scripts-refactor
Sep 9, 2026
Merged

refactor(scripts): extract transaction send helpers into transactions.ts#491
metapileks merged 1 commit into
developfrom
pileks/proposal-scripts-refactor

Conversation

@metapileks

@metapileks metapileks commented Sep 9, 2026

Copy link
Copy Markdown
Collaborator

Title.

Greptile Summary

This PR performs a behavior-preserving refactor of the script transaction utilities.

  • Moves transaction sending, confirmation, retry, and probe types into scripts/utils/transactions.ts.
  • Updates DAO action, futarchy proposal, and Squads utilities to import from the new module.
  • Removes the resulting transaction-helper dependency from squads.ts to daoActions.ts.

Confidence Score: 5/5

The PR appears safe to merge because the helper extraction preserves behavior and all repository callers use the new module.

No actionable failures remain; module resolution supports the new import path, and no caller, build configuration, or explicit export surface depends on the removed declarations in daoActions.ts.

Important Files Changed

Filename Overview
scripts/utils/transactions.ts Introduces the extracted transaction helper implementations and ProbeResult type without behavioral changes.
scripts/utils/daoActions.ts Replaces locally defined transaction helpers with imports from the new utility module.
scripts/utils/futarchyProposal.ts Redirects transaction-helper imports from daoActions.ts to transactions.ts.
scripts/utils/squads.ts Redirects the ProbeResult type import to its new module.

Reviews (1): Last reviewed commit: "refactor(scripts): extract transaction s..." | Re-trigger Greptile

@metapileks metapileks self-assigned this Sep 9, 2026
@github-actions

github-actions Bot commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

Repository Guard

  • Cargo.lock: pass
  • yarn.lock (sdk): pass
  • yarn.lock (root): pass
  • Repo guard: pass

Repository Guard

Cargo dependency pinning

  • Status: pass
  • Every programs/*/Cargo.toml dep uses =x.y.z, a path = .. workspace ref, or a git dep with a 40-char rev.

Cross-program Anchor/Solana version consistency

  • Status: pass
  • anchor-lang and anchor-spl are pinned to the version declared in repo-guard.toml across every program.

solana-program crate pin

  • Status: pass
  • Every solana-program = "=X" declaration is =1.17.14 (locked to match Cargo.lock).

Anchor.toml solana_version

  • Status: pass
  • Anchor.toml declares solana_version = "1.17.34" (local-dev install for anchor test).

Crate minimum age

  • Status: pass
  • All Cargo deps changed by this PR are at least 14 days old on crates.io.

Yarn package.json pinning

  • Status: pass
  • All package.json deps use exact versions (no ^, ~, ranges).

npm minimum age

  • Status: pass
  • All npm deps changed by this PR are at least 14 days old.

Workflow toolchain consistency

  • Status: pass
  • Every workflow declares anchor-version: 0.29.0.
  • Per-file solana-cli-version values match [toolchain.workflow_solana_cli] in repo-guard.toml.

GitHub Action SHA pinning

  • Status: pass
  • Every third-party action is pinned to a SHA in [actions.sha_allowlist].

Sensitive program / config changes

  • Status: pass
  • No suspicious changes to program IDs, error enums, or sensitive files detected.

Overall status: pass

Lockfile freshness (Cargo.lock + yarn.lock) is checked by the workflow directly and cannot be bypassed. The sensitive-diff section is a review hint - CODEOWNERS handles the actual merge gate.

@metapileks
metapileks merged commit 13295c0 into develop Sep 9, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant