Skip to content

fix(sdk): use squads vault as payerKey in squadsProposalCreateTx - #492

Merged
metapileks merged 1 commit into
developfrom
pileks/sdk-signer-fix
Sep 9, 2026
Merged

fix(sdk): use squads vault as payerKey in squadsProposalCreateTx#492
metapileks merged 1 commit into
developfrom
pileks/sdk-signer-fix

Conversation

@metapileks

@metapileks metapileks commented Sep 9, 2026

Copy link
Copy Markdown
Collaborator

Title.

Greptile Summary

This PR updates Squads proposal transaction construction so the DAO’s index-zero multisig vault is the stored transaction-message payer, while retaining the caller-provided payer for proposal account rent. It also increments the SDK prerelease version.

  • Derives the Squads vault from the DAO multisig.
  • Uses that vault as the inner transaction-message payer.
  • Preserves caller-managed funding and signing for the outer creation transaction.
  • Bumps the SDK package to 0.1.1-alpha.1.

Confidence Score: 5/5

The PR appears safe to merge; the payer change aligns with established Squads vault-transaction construction patterns and no actionable regression was identified.

The derived vault matches the transaction’s existing vault index, while the caller-provided payer continues funding account creation and the outer transaction, so proposal creation and later execution retain their intended signer responsibilities.

Important Files Changed

Filename Overview
sdk/src/futarchy/v0.6/FutarchyClient.ts Changes the stored Squads transaction-message payer to the matching index-zero multisig vault while preserving the external rent payer.
sdk/package.json Advances the SDK prerelease package version from 0.1.1-alpha.0 to 0.1.1-alpha.1.

Reviews (1): Last reviewed commit: "fix(sdk): use squads vault as payerKey i..." | Re-trigger Greptile

Context used (3)

@metapileks
metapileks requested a review from meta-reid September 9, 2026 19:02
@metapileks metapileks self-assigned this Sep 9, 2026
@github-actions

github-actions Bot commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

Repository Guard

  • Cargo.lock: pass
  • yarn.lock (sdk): pass
  • yarn.lock (root): pass
  • Repo guard: pass

Repository Guard

Cargo dependency pinning

  • Status: pass
  • Every programs/*/Cargo.toml dep uses =x.y.z, a path = .. workspace ref, or a git dep with a 40-char rev.

Cross-program Anchor/Solana version consistency

  • Status: pass
  • anchor-lang and anchor-spl are pinned to the version declared in repo-guard.toml across every program.

solana-program crate pin

  • Status: pass
  • Every solana-program = "=X" declaration is =1.17.14 (locked to match Cargo.lock).

Anchor.toml solana_version

  • Status: pass
  • Anchor.toml declares solana_version = "1.17.34" (local-dev install for anchor test).

Crate minimum age

  • Status: pass
  • All Cargo deps changed by this PR are at least 14 days old on crates.io.

Yarn package.json pinning

  • Status: pass
  • All package.json deps use exact versions (no ^, ~, ranges).

npm minimum age

  • Status: pass
  • All npm deps changed by this PR are at least 14 days old.

Workflow toolchain consistency

  • Status: pass
  • Every workflow declares anchor-version: 0.29.0.
  • Per-file solana-cli-version values match [toolchain.workflow_solana_cli] in repo-guard.toml.

GitHub Action SHA pinning

  • Status: pass
  • Every third-party action is pinned to a SHA in [actions.sha_allowlist].

Sensitive program / config changes

  • Status: pass
  • No suspicious changes to program IDs, error enums, or sensitive files detected.

Overall status: pass

Lockfile freshness (Cargo.lock + yarn.lock) is checked by the workflow directly and cannot be bypassed. The sensitive-diff section is a review hint - CODEOWNERS handles the actual merge gate.

@metapileks
metapileks merged commit 1a8d0d7 into develop Sep 9, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants