PHP 8.4 compatibility: explicit nullable parameter type - #37
Merged
Merged
Conversation
Under PHP 8.4, an implicitly-nullable parameter (a non-nullable type with a `null` default) emits "Implicitly marking parameter as nullable is deprecated". Downloader's constructor declared `ClientInterface $client = null`, so it fires once per class compile on 8.4. Mark the parameter explicitly nullable. The property is already documented `@var ?ClientInterface`, so this only makes the signature match the intent; behaviour is unchanged.
|
Any chance on merging that @mhujer ? Thats probably the easiest fix that ever existed in php :) |
Owner
|
@KminekMatej merged, but I don't have any capacity to dedicate to this library anymore (I haven't used it myself for more than 3 years) |
|
@mhujer Thats pretty much understandable - in the meantime I already found a fork of your library, with this minor bug already fixed, but under active development. If you dont have any plans of continuing the development, perhaps pointing to that fork in readme (and probably marking this lib in packagist deprecated) could help the incoming users as well: https://github.com/webwingscz/fio-api-php |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Under PHP 8.4, an implicitly-nullable parameter (a non-nullable type with a
nulldefault) emits "Implicitly marking parameter as nullable is deprecated". Downloader's constructor declaredClientInterface $client = null, so it fires once per class compile on 8.4.Mark the parameter explicitly nullable. The property is already documented
@var ?ClientInterface, so this only makes the signature match the intent; behaviour is unchanged.