Skip to content

Fix Issue #128 regarding the images not appearing in markdown docs. - #129

Open
Norbert Cygiert (norbertcygiert) wants to merge 2 commits into
microsoft:masterfrom
norbertcygiert:master
Open

Fix Issue #128 regarding the images not appearing in markdown docs.#129
Norbert Cygiert (norbertcygiert) wants to merge 2 commits into
microsoft:masterfrom
norbertcygiert:master

Conversation

@norbertcygiert

Copy link
Copy Markdown

Simple fix, changed the name of the images folder to the correct one, now images appear normally.

@norbertcygiert

Copy link
Copy Markdown
Author

@microsoft-github-policy-service agree

@ManyaS-Git Manya Sharma (ManyaS-Git) left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified and looks correct — approving.

Checklist confirmed:

  • Both images exist in the repo at the resolved paths: .images/decision_python_scoring.png and .images/python_training_diag.png (confirmed against the master tree).
  • From .docs/python_scoring.md, ../.images/decision_python_scoring.png resolves to <root>/.images/decision_python_scoring.png — correct.
  • Same for .docs/python_training.md../.images/python_training_diag.png.
  • The fix exactly matches the bug described in issue #128 ("'images' instead of '.images'").
  • Bonus: both files now end with a trailing newline (previously \ No newline at end of file), which is good hygiene.

Minor suggestions (non-blocking):

  1. This fixes the two files in the issue, but the same images/ vs .images/ typo may exist elsewhere in the docs. It may be worth a quick repo-wide grep for src="images/ / ](images/ (without the dot) and a follow-up PR if any other markdown files are affected.
  2. Consider adding a tiny CI link-checker (e.g., markdown-link-check) so broken doc links get caught automatically in future PRs.

Nice minimal fix — thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants