docs: fix broken marketplace link and two markup errors#3590
Open
EduardF1 wants to merge 1 commit into
Open
Conversation
Fix the double-encoded VS Marketplace URL in Nightly Builds, remove the stray handbook preamble closing tag, and close the inline code quote in the declaration publishing docs.
EduardF1
force-pushed
the
docs/fix-broken-link-and-markup
branch
from
f5d8e98 to
30a8f06
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Three small, objectively-correct documentation fixes in the English copy.
1.
Nightly Builds.md— broken VS Marketplace link (404)The link to the JavaScript and TypeScript Nightly extension was double-encoded:
itemName%253D....%25is an encoded%, so the server receivesitemName%3D...(literal%3D) instead ofitemName=..., and the page returns HTTP 404. Replacing%253Dwith=resolves to HTTP 200..../items?itemName%253Dms-vscode.vscode-typescript-next→ 404.../items?itemName=ms-vscode.vscode-typescript-next→ 2002.
handbook-v2/Basics.md— stray</a>in preamble HTMLThe
preamblefront-matter HTML contained an extra closing</a>with no matching opening tag (theGetting Startedanchor was already closed). Removed the orphan tag.3.
declaration-files/Publishing.md— unmatched quote in code spanAn inline code span opened a double-quote that was never closed:
"./index.v3.d.ts. Closed it to"./index.v3.d.ts"to match the surrounding"package-name"example.Validation