Harden release skill guidance - #555
Closed
Yuge Zhang (ultmaster) wants to merge 1 commit into
Closed
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR hardens the release skill documentation to make the Agent Lightning stable-release process more deterministic and less error-prone, especially around version bump failure modes and GitHub Actions run selection.
Changes:
- Adds guidance about partial/failed version bumps and the need to reconcile version state before retrying.
- Clarifies the relationship between
tests.ymlandpypi-release.ymltest/build coverage and explains how runtime version checks are performed in CI. - Makes PR merge and tag-triggered workflow run lookup more deterministic (explicit merge method + head commit matching; workflow+tag filtering for
gh run list).
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| - `agentlightning/__init__.py` | ||
| 4. Confirm the canonical default branch is already green before branching from | ||
| it. A release branch inherits every failure that main is carrying. | ||
| it. Resolve its current commit with `gh api repos/OWNER/REPO/commits/BRANCH` |
Comment on lines
+59
to
+63
| The bump updates `pyproject.toml` before uv finishes resolving and writing the | ||
| lockfile. If resolution or network access fails, the command can exit after a | ||
| partial bump. Inspect `git diff` after any failure and restore or reconcile all | ||
| three version files before retrying; blindly rerunning a partial patch bump can | ||
| advance the version twice. |
Comment on lines
+104
to
+111
| resolve the reviewed head with | ||
| `gh pr view <pr> --repo OWNER/REPO --json headRefOid` and pass both an explicit | ||
| permitted method and `--match-head-commit` to `gh pr merge`. The canonical | ||
| repository currently permits only squash merges, for example: | ||
|
|
||
| ```bash | ||
| gh pr merge <pr> --repo OWNER/REPO --squash --match-head-commit <head-sha> | ||
| ``` |
Contributor
Author
|
Superseded by #552, which now contains this release-skill commit together with the skills README rewrite. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification