Skip to content
This repository was archived by the owner on Nov 16, 2023. It is now read-only.

Added ability to localize based on user's location - #161

Open
Ari Zilnik (azilnik) wants to merge 3 commits into
microsoft:masterfrom
azilnik:location-data
Open

Added ability to localize based on user's location#161
Ari Zilnik (azilnik) wants to merge 3 commits into
microsoft:masterfrom
azilnik:location-data

Conversation

@azilnik

Copy link
Copy Markdown

Instead of listing position options as elsewhere, it might be possible to localize to the user's own location, using the user's IP to detect where he or she is, and render in the site copy.

This would help make possible remote workers feel encouraged to apply.

@msftclas

Microsoft Contribution License Agreements (msftclas) commented Sep 26, 2018

Copy link
Copy Markdown

CLA assistant check
All CLA requirements met.

@leovarmak

Copy link
Copy Markdown

This is nice!
Did you forget to remove the API Key ?

@azilnik

Copy link
Copy Markdown
Author

Karthik Varma (@leovarmak) good call out! I removed the API Key. pavel (@prichodko), I added a comment in location.js about including an API key if this were to be merged. Here is what it looks like with the API key all set up properly.

screen shot 2018-10-09 at 5 36 11 pm

@prichodko

pavel (prichodko) commented Oct 9, 2018

Copy link
Copy Markdown
Contributor

Hey Ari Zilnik (@azilnik), thanks for you contribution! Although it's a neat feature I am afraid it could confuse people into thinking there is a Microsoft office hiring in their city, which probably is not true.

What do you think?

@azilnik

Copy link
Copy Markdown
Author

It's a good call-out pavel (@prichodko)! I think it would work if there are remote opportunities. Hmm I wonder if there's a way to get the user's location data and match it to open roles, and indicate whether you're hiring in that particular location. Thoughts?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants