Skip to content

[PQC][REBASE&FF] Update to Dynamic Caching - #1905

Open
Joey Vagedes (Javagedes) wants to merge 3 commits into
microsoft:dev/202511/post-quantum-stagingfrom
Javagedes:personal/joeyvagedes/hashallbyguid
Open

[PQC][REBASE&FF] Update to Dynamic Caching#1905
Joey Vagedes (Javagedes) wants to merge 3 commits into
microsoft:dev/202511/post-quantum-stagingfrom
Javagedes:personal/joeyvagedes/hashallbyguid

Conversation

@Javagedes

Copy link
Copy Markdown
Contributor

Description

This commit updates DxeImageVerificationLib in three ways:

  1. Updates the current caching mechanism from a static cache with specific hashing algorithms supported, to a dynamic caching mechanism with support for any hashing algorithm supported by BaseCryptLib's HashAllByGuid.
  2. Uses AuthenticodeLib to generate the authenticode image and extract the WIN_CERTIFICATEs.
  3. Cleans up DB / DBX iteration to use the same underlying walker so that each check (IsHashInDB<X>, IsCertInDB<X>, contains only the logic needed to check if a specific entry in the DB / DBX matches the specific contents.
  • Impacts functionality?
  • Impacts security?
  • Breaking change?
  • Includes tests?
  • Includes documentation?

How This Was Tested

Image Validation Test app continues to pass.

Integration Instructions

N/A

@codecov-commenter

Codecov Comments Bot (codecov-commenter) commented Sep 3, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 95.47170% with 12 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (dev/202511/post-quantum-staging@506bbae). Learn more about missing BASE report.

Files with missing lines Patch % Lines
...ityPkg/Library/DxeImageVerificationLib2/Database.c 96.08% 6 Missing and 1 partial ⚠️
...DxeImageVerificationLib2/DxeImageVerificationLib.c 86.36% 3 Missing ⚠️
...curityPkg/Library/DxeImageVerificationLib2/Cache.c 97.14% 1 Missing ⚠️
...ityPkg/Library/DxeImageVerificationLib2/Iterator.c 96.55% 1 Missing ⚠️
Additional details and impacted files
@@                        Coverage Diff                        @@
##             dev/202511/post-quantum-staging   #1905   +/-   ##
=================================================================
  Coverage                                   ?   4.04%           
=================================================================
  Files                                      ?     172           
  Lines                                      ?   39542           
  Branches                                   ?     517           
=================================================================
  Hits                                       ?    1601           
  Misses                                     ?   37922           
  Partials                                   ?      19           
Flag Coverage Δ
SecurityPkg 4.04% <95.47%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants