Open
Bound concurrent transaction_mode => 'new' launches#322
transaction_mode => 'new' launches#322Conversation
6 tasks
Co-authored-by: pinodeca <32303022+pinodeca@users.noreply.github.com>
Co-authored-by: pinodeca <32303022+pinodeca@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add admission control for concurrent 'new' launches
Bound concurrent Jul 30, 2026
transaction_mode => 'new' launches
pinodeca
marked this pull request as ready for review
July 31, 2026 00:37
Add an E2E assertion that a transaction_mode => 'new' launch which acquires an admission slot and then fails inside the loopback session still releases its slot, plus clarifying comments on the advisory-lock namespace and the poll-loop interrupt behavior.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
df.start(..., transaction_mode => 'new')opened an extra loopback backend per caller with no cross-session cap, so bursty submissions could drive backend growth towardmax_connections. This change adds database-wide admission control, bounded rejection, and explicit coverage/documentation for the supported concurrency envelope.Admission control for
'new'launchespg_durable.max_new_transaction_starts(default2)pg_durable.new_transaction_start_timeout(default5s)Sharper failure modes and diagnostics
lock_timeoutstatement_timeoutapplication_nameto make them identifiable in backend inspection.No partial state on rejected launches
'new'launches do not leave behind partialdf.instances,df.nodes, or runnable engine state.transaction_mode => 'caller'behavior remains unchanged.Concurrency coverage
'new'starts via separate PostgreSQL client sessions and proves:Docs / operating envelope