Track #169 resolution: regression test for terminal event payload IDs - #324
Merged
Conversation
pinodeca
force-pushed
the
test/terminal-event-payload-ids-169
branch
from
July 30, 2026 21:41
e527c6e to
a078b3b
Compare
Terminal OrchestrationFailed events previously serialized instance_id="" and execution_id=0 in their duroxide.history event_data payload. This was an upstream duroxide bug (microsoft/duroxide#35), fixed by the duroxide 0.1.30 bump already shipped in pg_durable 0.2.5 (#305) — no extension-side change was required. This change only records that resolution and guards against regression: - CHANGELOG: add a Fixed entry under [0.2.5] documenting the resolution. - Add tests/e2e/sql/26_terminal_event_payload_ids.sql covering both the cancellation and plain-failure terminal paths. It resolves the provider schema via df.duroxide_schema(), polls for the async terminal-event flush, and asserts payload identifiers match the history row. Relates to #169
pinodeca
force-pushed
the
test/terminal-event-payload-ids-169
branch
from
July 30, 2026 21:43
a078b3b to
675cdaa
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Issue #169 (terminal
OrchestrationFailedevents serializinginstance_id=""/execution_id=0in theduroxide.historyevent_datapayload) was an upstream duroxide bug (microsoft/duroxide#35, fixed by microsoft/duroxide#36) that shipped in duroxide v0.1.30. pg_durable v0.2.5 already bumpedduroxideto=0.1.30(#305), so the issue is fixed with no extension-side code change.This PR does not fix anything itself — it records the resolution and guards against regression:
Fixedentry under[0.2.5]documenting that Cancellation failure history event has empty instance_id and execution_id=0 in payload #169 is resolved by the duroxide 0.1.30 bump (no workaround needed; the trigger approach explored in Preserve cancellation event payload identifiers induroxide.history#180 was closed in favor of the upstream fix).tests/e2e/sql/26_terminal_event_payload_ids.sqlcovering both terminal paths (cancellation and plain failure), per the suggestion in Cancellation failure history event has empty instance_id and execution_id=0 in payload #169. It:df.duroxide_schema()so it works on fresh (_duroxide) and legacy (duroxide) installs,OrchestrationFailedpayload has a non-emptyinstance_idand a numeric, non-zeroexecution_idmatching the history row, plus a broader sweep over all events for the instance.Verification
26_terminal_event_payload_ids ... PASS).Relates to #169 (already closed; this is tracking + regression coverage, not the fix).