Skip to content

test: add unit tests for pet-windows-registry crate (Fixes #389)#442

Merged
karthiknadig merged 1 commit into
mainfrom
test/issue-389-windows-registry
Jun 26, 2026
Merged

test: add unit tests for pet-windows-registry crate (Fixes #389)#442
karthiknadig merged 1 commit into
mainfrom
test/issue-389-windows-registry

Conversation

@karthiknadig

Copy link
Copy Markdown
Member

Add 4 new unit tests to pet-windows-registry (10 total, up from 6):

  • try_from returns None for plain env without cache
  • Sync from source with None cache clears shared state
  • Sync is idempotent (double-sync produces same result)
  • GlobalFiltered with Conda kind triggers sync

Fixes #389

@github-actions

github-actions Bot commented Apr 22, 2026

Copy link
Copy Markdown

Performance Report (Linux) ✅

Metric PR (P50) PR (P95) Baseline (P50) Delta Change
Server Startup 0ms 1ms 1ms -1ms -100.0%
Full Refresh 52ms 466ms 65ms -13ms -20.0%

Results based on 10 iterations. P50 = median, P95 = 95th percentile.


Legend
  • 🚀 Significant speedup (>100ms faster)
  • ✅ Faster than baseline
  • ➖ No significant change
  • 🔺 Slower than baseline (>100ms)
  • ⚠️ Significant slowdown (>500ms)

@github-actions

github-actions Bot commented Apr 22, 2026

Copy link
Copy Markdown

Test Coverage Report (Linux)

Metric Value
Current Coverage 80.0%
Base Branch Coverage 79.9%
Delta .1% ✅

Coverage increased! Great work!

@github-actions

github-actions Bot commented Apr 22, 2026

Copy link
Copy Markdown

Performance Report (macOS)

Metric PR (P50) PR (P95) Baseline (P50) Delta
Server Startup 72ms 575ms 62ms 10ms
Full Refresh 144ms 29146ms 132ms 12ms

Results based on 10 iterations. P50 = median, P95 = 95th percentile.


Legend
  • 🚀 Significant speedup (>100ms faster)
  • ✅ Faster than baseline
  • ➖ No significant change
  • 🔺 Slower than baseline (>100ms)
  • ⚠️ Significant slowdown (>500ms)

@github-actions

github-actions Bot commented Apr 22, 2026

Copy link
Copy Markdown

Performance Report (Windows) ✅

Metric PR (P50) PR (P95) Baseline (P50) Delta Change
Server Startup 10ms 13ms 9ms 1ms 11.1%
Full Refresh 145ms 345ms 153ms -8ms -5.2%

Results based on 10 iterations. P50 = median, P95 = 95th percentile.


Legend
  • 🚀 Significant speedup (>100ms faster)
  • ✅ Faster than baseline
  • ➖ No significant change
  • 🔺 Slower than baseline (>100ms)
  • ⚠️ Significant slowdown (>500ms)

@github-actions

github-actions Bot commented Apr 22, 2026

Copy link
Copy Markdown

Test Coverage Report (Windows)

Metric Value
Current Coverage 77.03%
Base Branch Coverage 76.94%
Delta 0.09% ✅

Coverage increased! Great work!

@karthiknadig
karthiknadig force-pushed the test/issue-389-windows-registry branch from 1c2c403 to 34cc095 Compare April 23, 2026 15:48
@karthiknadig
karthiknadig marked this pull request as ready for review April 23, 2026 16:32
eleanorjboyd
eleanorjboyd previously approved these changes Apr 23, 2026
@karthiknadig
karthiknadig force-pushed the test/issue-389-windows-registry branch from 0e2d0d0 to b93663c Compare June 26, 2026 04:59
@karthiknadig
karthiknadig merged commit 5b765ef into main Jun 26, 2026
47 of 48 checks passed
@karthiknadig
karthiknadig deleted the test/issue-389-windows-registry branch June 26, 2026 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Coverage: ranked plan to move workspace coverage toward 90%

3 participants