Skip to content

Rewording an error message#14561

Merged
sean-mcmanus merged 6 commits into
mainfrom
bobbrow/rewordErrorMessage
Jul 7, 2026
Merged

Rewording an error message#14561
sean-mcmanus merged 6 commits into
mainfrom
bobbrow/rewordErrorMessage

Conversation

@bobbrow

@bobbrow bobbrow commented Jul 2, 2026

Copy link
Copy Markdown
Member

Fixes: #8227

PR for the native side is in progress

@bobbrow bobbrow requested a review from a team as a code owner July 2, 2026 23:36
@github-project-automation github-project-automation Bot moved this to Pull Request in cpptools Jul 2, 2026
@sean-mcmanus sean-mcmanus requested a review from Copilot July 2, 2026 23:59

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the user-facing messaging shown when #include resolution fails, aiming to address confusion reported in #8227 about “Squiggles are disabled…” wording.

Changes:

  • Rewords the #include errors detected... squiggle-disable messages in nativeStrings.json.
  • Renames three native string localization keys (adds ..._disabled2 variants).
  • Updates the Extension workspace VS Code setting for files.insertFinalNewline (JSON).

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.

File Description
Extension/src/nativeStrings.json Rewords the include-error squiggle-disable messages (and renames the corresponding localization keys).
Extension/.vscode/settings.json Changes JSON editor setting files.insertFinalNewline to true.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread Extension/src/nativeStrings.json Outdated
Comment thread Extension/src/nativeStrings.json Outdated
Comment thread Extension/src/nativeStrings.json Outdated
Comment thread Extension/.vscode/settings.json Outdated

@sean-mcmanus sean-mcmanus left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you remove the "2" from the keys? There doesn't appear to be a reason for that.

@bobbrow

bobbrow commented Jul 6, 2026

Copy link
Copy Markdown
Member Author

Can you remove the "2" from the keys? There doesn't appear to be a reason for that.

The purpose is to create a new id so that there is not an attempted replacement being done in the translated strings while we wait for translation updates. (the old strings have a {0} in them)

@sean-mcmanus sean-mcmanus added this to the 1.33.4 milestone Jul 6, 2026
@sean-mcmanus sean-mcmanus self-requested a review July 6, 2026 18:45
sean-mcmanus
sean-mcmanus previously approved these changes Jul 6, 2026
@sean-mcmanus sean-mcmanus merged commit 24d299f into main Jul 7, 2026
6 checks passed
@sean-mcmanus sean-mcmanus deleted the bobbrow/rewordErrorMessage branch July 7, 2026 22:52
@github-project-automation github-project-automation Bot moved this from Pull Request to Done in cpptools Jul 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

confusing message: "Squiggles are disabled for this translation unit ..."

3 participants