Rewording an error message#14561
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the user-facing messaging shown when #include resolution fails, aiming to address confusion reported in #8227 about “Squiggles are disabled…” wording.
Changes:
- Rewords the
#include errors detected...squiggle-disable messages innativeStrings.json. - Renames three native string localization keys (adds
..._disabled2variants). - Updates the Extension workspace VS Code setting for
files.insertFinalNewline(JSON).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| Extension/src/nativeStrings.json | Rewords the include-error squiggle-disable messages (and renames the corresponding localization keys). |
| Extension/.vscode/settings.json | Changes JSON editor setting files.insertFinalNewline to true. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
sean-mcmanus
left a comment
There was a problem hiding this comment.
Can you remove the "2" from the keys? There doesn't appear to be a reason for that.
The purpose is to create a new id so that there is not an attempted replacement being done in the translated strings while we wait for translation updates. (the old strings have a |
Fixes: #8227
PR for the native side is in progress