Skip to content

Improve Omni Chat window and voice ownership - #330886

Merged
Megan Rogge (meganrogge) merged 23 commits into
mainfrom
megrogge/fix-omni-window-voice
Aug 14, 2026
Merged

Improve Omni Chat window and voice ownership#330886
Megan Rogge (meganrogge) merged 23 commits into
mainfrom
megrogge/fix-omni-window-voice

Conversation

@meganrogge

@meganrogge Megan Rogge (meganrogge) commented Aug 14, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Summary

  • restore backend Voice Mode playback for requests routed through Omni Chat and correlate routed sessions through completion
  • defer confirmation/question narration until Omni's dispatch acknowledgement finishes, then revalidate and request narration
  • keep backend-native session identity consistent across session_context, narration, session-info queries, and spoken approval dispatch
  • stop stale pending narration when the user answers manually and suppress misleading dispatch acknowledgements/local fallback behavior
  • persist dismissed CI-failure cards by exact session/head occurrence while allowing later failures to surface
  • keep session attachments limited to provider-backed references that can actually be attached, sort them newest-first, and group by workspace only when multiple workspace groups exist
  • make Omni the exclusive voice owner while open, harden routing/model lifecycles, and preserve the existing Agents-window-only design

Testing

  • manually verified backend completion and confirmation narration flows in Omni Chat
  • npm run transpile-client -- --quiet
  • Voice client/controller/tool-dispatch suites: 267 passing
  • Sessions routing and Chat Context suites: 22 passing
  • targeted ESLint for changed TypeScript files
  • git diff --check

Fixes #330909

@meganrogge
Fix Omni Chat window and voice ownership
6dfdc12 
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot-Session: 38881cae-54c4-44ea-9f5b-e0a2874c2979
Copilot AI balanced review requested due to automatic review settings August 14, 2026 16:17
@meganrogge Megan Rogge (meganrogge) added this to the 1.134.0 milestone Aug 14, 2026
Copilot AI reviewed Aug 14, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Centers Omni Chat in its invoking window and transfers Voice Mode playback and chat-input visuals to Omni while open.

Changes:

  • Centers Omni Chat instead of restoring its previous position.
  • Adds observable Omni open-state ownership across chat surfaces.
  • Routes background audio through Omni during voice initialization.
Show a summary per file
File Description
src/vs/workbench/contrib/chat/test/common/chatInputWindow.test.ts Tests centered bounds.
src/vs/workbench/contrib/chat/test/browser/voiceClient/voiceSessionController.test.ts Tests open state and initializing playback.
src/vs/workbench/contrib/chat/common/chatInputWindow.ts Adds centering helper.
src/vs/workbench/contrib/chat/browser/widgetHosts/viewPane/chatViewPane.ts Suppresses panel voice visuals.
src/vs/workbench/contrib/chat/browser/widget/input/chatInputPart.ts Assigns voice controls to Omni.
src/vs/workbench/contrib/chat/browser/voiceClient/voiceSessionController.ts Exposes open state and expands Omni playback ownership.
src/vs/workbench/contrib/chat/browser/chatInputWindow/chatInputWindowService.ts Centers Omni and binds its voice decorations.
src/vs/sessions/contrib/chat/test/browser/newChatVoiceTarget.test.ts Tests Omni ownership exclusion.
src/vs/sessions/contrib/chat/browser/newChatVoice.ts Suppresses new-composer voice ownership.
src/vs/sessions/contrib/chat/browser/newChatInput.ts Updates composer voice controls reactively.
src/vs/sessions/contrib/chat/browser/chatView.ts Suppresses session voice visuals.

Review details

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

  • Files reviewed: 11/11 changed files
  • Comments generated: 1
  • Review effort level: Balanced

Comment thread src/vs/workbench/contrib/chat/browser/voiceClient/voiceSessionController.ts
@github-actions

github-actions Bot commented Aug 14, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Base: f764694f Current: 5ef1bd8a

No screenshot changes.

@meganrogge
Retain Omni Chat position and narration ownership
c675e5e 
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot-Session: 38881cae-54c4-44ea-9f5b-e0a2874c2979
@meganrogge
Ensure Omni announces questions and responses
8160386 
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot-Session: 38881cae-54c4-44ea-9f5b-e0a2874c2979
@meganrogge
Narrate transcript-only Omni responses
cb135e9 
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot-Session: 38881cae-54c4-44ea-9f5b-e0a2874c2979
@meganrogge
Fix Omni response and answer voice sync
90b2921 
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot-Session: 38881cae-54c4-44ea-9f5b-e0a2874c2979
@meganrogge
Fallback when Omni narration sends no audio
24e5354 
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot-Session: 38881cae-54c4-44ea-9f5b-e0a2874c2979
@meganrogge
Narrate coalesced Omni completions
7ad5702 
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot-Session: 38881cae-54c4-44ea-9f5b-e0a2874c2979
@meganrogge
Narrate completed Omni response identities
051e5b3 
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot-Session: 38881cae-54c4-44ea-9f5b-e0a2874c2979
@meganrogge
Merge remote-tracking branch 'origin/main' into fix-omni-window-voice
c7a7445
@meganrogge
Fix Omni narration for unloaded routed sessions
96160ca 
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot-Session: 38881cae-54c4-44ea-9f5b-e0a2874c2979
@meganrogge
Fix Omni routed response ownership
ffd82c1 
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot-Session: 38881cae-54c4-44ea-9f5b-e0a2874c2979
@meganrogge
Sort session attachments by activity
a6ac0c8 
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot-Session: 38881cae-54c4-44ea-9f5b-e0a2874c2979
@meganrogge Megan Rogge (meganrogge) mentioned this pull request Aug 14, 2026
Closed
@meganrogge
Fix Omni pending question sizing
a25a3e9 
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot-Session: 38881cae-54c4-44ea-9f5b-e0a2874c2979
@meganrogge
Refine Omni session attachments
d0f0a8f 
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot-Session: 38881cae-54c4-44ea-9f5b-e0a2874c2979
@meganrogge
Use backend transcript for Omni narration
35c7566 
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot-Session: 38881cae-54c4-44ea-9f5b-e0a2874c2979
@meganrogge
Fix Omni voice response playback
c98475b
@meganrogge
Address Omni voice review findings
e7df928
@meganrogge
Fix Omni confirmation voice routing
cecbba6 
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot-Session: 38881cae-54c4-44ea-9f5b-e0a2874c2979
@meganrogge
Hide redundant session attachment category
1df08e2 
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot-Session: 38881cae-54c4-44ea-9f5b-e0a2874c2979
@meganrogge
Megan Rogge (meganrogge) marked this pull request as ready for review August 14, 2026 20:39
@meganrogge Megan Rogge (meganrogge) changed the title Fix Omni Chat window and voice ownership Improve Omni Chat window and voice ownership Aug 14, 2026
@meganrogge
Megan Rogge (meganrogge) enabled auto-merge (squash) August 14, 2026 20:40
@meganrogge
Fix Omni confirmation test narrowing
59be6c9 
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot-Session: 38881cae-54c4-44ea-9f5b-e0a2874c2979
dmitrivMS
Dmitriy Vasyura (dmitrivMS) reviewed Aug 14, 2026
View reviewed changes

@dmitrivMS Dmitriy Vasyura (dmitrivMS) left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AI Review: Full-diff review findings are inline.

Comment thread src/vs/workbench/contrib/chat/browser/voiceClient/voiceSessionController.ts
Comment thread src/vs/workbench/contrib/chat/browser/voiceClient/voiceSessionController.ts Outdated
Comment thread src/vs/workbench/contrib/chat/browser/voiceClient/voiceSessionController.ts Outdated
Comment thread src/vs/workbench/contrib/chat/browser/chatInputWindow/media/chatInputWindow.css
Comment thread src/vs/sessions/contrib/chat/test/browser/omniSessionRoutingAdapter.test.ts Outdated
Comment thread src/vs/workbench/contrib/chat/browser/actions/chatContext.ts Outdated
Comment thread src/vs/workbench/contrib/chat/browser/actions/chatContext.ts Outdated
@meganrogge
Address Omni voice review feedback
fda7e79 
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot-Session: b6b8b210-0298-4a0b-b387-5913e40c7fce
@meganrogge
Allow routed requests with model configuration
3df17f3 
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot-Session: b6b8b210-0298-4a0b-b387-5913e40c7fce
@meganrogge
Megan Rogge (meganrogge) enabled auto-merge (squash) August 14, 2026 22:00
@meganrogge
Megan Rogge (meganrogge) merged commit 9650e9c into main Aug 14, 2026
27 checks passed
@meganrogge
Megan Rogge (meganrogge) deleted the megrogge/fix-omni-window-voice branch August 14, 2026 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@benvillalobos Ben Villalobos (benvillalobos) benvillalobos approved these changes
@dmitrivMS Dmitriy Vasyura (dmitrivMS) Awaiting requested review from dmitrivMS

Assignees

@meganrogge Megan Rogge (meganrogge)

Labels

None yet

Projects

None yet

Milestone

1.134.0

Development

Successfully merging this pull request may close these issues.

Support Sessions-layer sessions in chat attachments

4 participants

@meganrogge @benvillalobos @dmitrivMS