Add persistent output locale override setting#6310
Open
Trenly wants to merge 10 commits into
Open
Conversation
* Add output.locale setting and schema support * Apply runtime language qualifier override for resource resolution * Include localized resw fallbacks in dev package and update docs/release notes Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
microsoft-github-policy-service
Bot
added
Issue-Feature
Trenly
commented
Jun 21, 2026
JohnMcPMS
reviewed
Jun 24, 2026
florelis
reviewed
Jun 26, 2026
florelis
requested changes
Jun 30, 2026
microsoft-github-policy-service
Bot
added
Needs-Author-Feedback
florelis
previously approved these changes
Jul 1, 2026
florelis
left a comment
florelis
left a comment
Member
There was a problem hiding this comment.
LGTM, but I'd want to hold off on merging until we have a plan for what to do with App Installer.
Member
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
@florelis - I get the same E2E test failures from my last checkout on
Recording.2026-07-01.224731.mp4 |
…tput-locale-override
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a new persisted output.locale user setting that lets WinGet override the UI/output language (via a supported BCP47 tag), and wires the setting into startup initialization so localized resources resolve accordingly. It also updates schema/docs/release notes and adjusts packaging to pick up localized winget.resw files during local builds.
Changes:
- Introduces
Setting::OutputLocale(settings mapping + validation/normalization against supported locale tags). - Applies the locale override at CLI startup via
ApplicationLanguages::PrimaryLanguageOverride. - Updates the settings schema + documentation + release notes, and adds packaging fallback to include localized
winget.reswfromLocalization\Resources\<locale>whenShared\Strings\<locale>is absent.
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/AppInstallerCommonCore/UserSettings.cpp | Adds supported-locale normalization and validation for the new output.locale setting. |
| src/AppInstallerCommonCore/Public/winget/UserSettings.h | Adds the OutputLocale setting enum value and JSON mapping to .output.locale. |
| src/AppInstallerCLITests/UserSettings.cpp | Adds unit tests covering default/valid/case-insensitive/invalid locale values. |
| src/AppInstallerCLIPackage/AppInstallerCLIPackage.wapproj | Adds build-time fallback PRIResource includes from Localization\\Resources\\<locale> for local builds. |
| src/AppInstallerCLICore/Core.cpp | Applies the persisted output locale override during startup initialization. |
| schemas/JSON/settings/settings.schema.0.2.json | Adds output.locale to the public settings schema with supported enum values. |
| doc/windows/package-manager/winget/settings.md | Documents the new output.locale setting for end users. |
| doc/Settings.md | Documents the new output.locale setting in the repo’s settings documentation. |
| doc/ReleaseNotes.md | Adds a release note entry for the new output locale override feature. |
Comment on lines
+87
to
+92
| try | ||
| { | ||
| // Always apply the setting value, including empty string, to clear a persisted override from | ||
| // previous sessions. PrimaryLanguageOverride is package-scoped and persists across sessions. | ||
| winrt::Windows::Globalization::ApplicationLanguages::PrimaryLanguageOverride(Utility::ConvertToUTF16(localeTag)); | ||
| } |
Member
There was a problem hiding this comment.
I don't think this applies, as we don't use qualifiers anywhere AFAIK
Member
|
/azp run |
|
Azure Pipelines: Successfully started running 1 pipeline(s). |
florelis
approved these changes
Jul 14, 2026
Member
|
Looks like we will need to reset the override in App Installer. Internal PR number for that: 16173490 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📖 Description
Add a persistent
output.localeuser setting that allows overriding WinGet interface language via a BCP47 tag.This PR also ensures the override affects MRT resource resolution by setting both
ApplicationLanguages::PrimaryLanguageOverrideand the globalLanguagequalifier, and updates packaging so local builds can include localizedwinget.reswfiles fromLocalization\Resources\<locale>whenShared\Strings\<locale>is absent.🔗 References
Resolves #422
🔍 Validation
✅ Checklist
📋 Issue Type
Microsoft Reviewers: Open in CodeFlow