sys: Use DXCore for accelerator discovery - #1351
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Zhenchao Ni (zhenchaoni)
left a comment
There was a problem hiding this comment.
I found two device-to-LUID matching issues that can produce missing or incorrect identifiers.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
The review discussion exposed that top-level LUID assignment should not depend on ORT-to-WMI name matching. Commit 6563659 replaces that design: DXCore now owns each GPU/NPU row and returns its name, hardware IDs, and LUID together; WMI/PnP only enriches descriptive fields. This also handles multiple physical adapters with identical display names because each DXCore row already carries its own identity. |
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
Latest Qualcomm retest confirms the native path: DXCore returned Adreno X1-85 ( |
Summary
winml sysDiscovery behavior
DXCore returns the adapter name, hardware IDs, and LUID together.
winml sysnow creates accelerator rows from that inventory, then joins WMI/PnP metadata by hardware ID or name. ONNX Runtime remains responsible only for execution-provider inventory and EP-specific facts; it no longer assigns the top-level device LUID.CPU discovery remains WMI-based and reports
LUID: N/Abecause CPU devices do not have a Windows graphics/compute adapter LUID.Hardware observations
--ep nvtensorrtrtx --device gpu0x00000000_0x000175F5--ep qnn --device gpu0x00000000_0x00012AC1--ep qnn --device npu0x00000000_0x000135AAAll three accelerator paths were revalidated through DXCore on this revision. QNN GPU inference completed at 0.743 ms mean latency and 1,345.89 samples/sec.
Validation