Conversation
mike1pol
requested changes
Mar 25, 2019
| } | ||
|
|
||
| module.exports = Dadata; | ||
| export default Dadata; |
Owner
There was a problem hiding this comment.
в этом случае не будет работать с node.js
Owner
There was a problem hiding this comment.
Для совместимости с нодой и клиентской частью нужно делать экспорт по другому
module.exports = Dadata;
module.exports.default = Dadata;
| req.write(JSON.stringify(request)); | ||
| req.end(); | ||
| }); | ||
| return fetch(this._path(api), options); |
Owner
There was a problem hiding this comment.
Желательно уже тут делать fetch-json
Owner
There was a problem hiding this comment.
так-же нужно добавить полифил node-fetch
| */ | ||
| _client(api, params) { | ||
| const request = Object.assign({ | ||
| let request = Object.assign({ |
| count: 10 | ||
| }, params); | ||
| const options = { | ||
| let options = { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Приветствую! Спасибо за проделанную работу.
У меня появилась задача связанная с сервисом Dadata.ru, в поисках нашел ваш пакет.
Я изменил некоторые моменты в коде, приватный метод client(), добавил метода, поправил файл example.
Цель правки избавиться от пакета https. и использовать fetch.
Пожалуйста посмотрите изменения. Спасибо!
П.С.
Я не являюсь FrontEnd разработчиком, не судите строго, если что. Я немного комменты поправил, думается что должен быть пробел после описания метода