Upgrade every dependency the toolchain can carry - #51
Merged
Conversation
npm audit reported one low advisory in the root project (esbuild) and six high ones in both Workers fixtures (ws, undici, reached through wrangler and miniflare). All three lockfiles now report zero. The fixtures' jump to vitest-pool-workers 0.21 was not a version bump on its own. The package dropped its `/config` entry point, so both vitest.config.ts files now compose `cloudflareTest()` as a Vite plugin; `ProvidedEnv` became `Cloudflare.Env`; and per-test storage isolation is no longer implicit, so each setup.ts resets explicitly. That last one is load-bearing: without the reset, 28 tests fail on tables leaked from the previous test, which is the isolation the suites were always relying on. @types/node is pinned to the 24 line everywhere rather than the newest release. The fixtures were on 25, an EOL line, and CI pins Node 24 LTS; types that describe a runtime nobody runs are a trap, not an upgrade. Two majors are deliberately left behind. TypeScript 7 removes `moduleResolution: node10` and does not expose the compiler API (`transpileModule`, `ModuleKind`, `ScriptTarget`) that the generator harness compiles fixtures with. @bufbuild/protobuf 2 would rewrite 287 message constructions and the plugin's stdin decode path. Neither buys a single resolved advisory.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
npm auditreported one low advisory in the root project and six high ones in both Workers fixtures. All three lockfiles now report zero.What moved
esbuild0.27.3^0.28.2— clears GHSA-g7r4-m6w7-qqqr@cloudflare/workers-types^4^5.20260815.1wrangler^4.63^4.123.0— clears 6 highws/undiciadvisories@cloudflare/vitest-pool-workers^0.12.10^0.21.3vitest^3.2.4^4.1.10typescript^5.5.2^5.9.3, matching roothono,prettier, and thejavynpm shim were already current.Changes the upgrades forced
vitest-pool-workers 0.21 is not a drop-in:
/configentry point, so bothvitest.config.tscomposecloudflareTest()as a Vite plugin alongsidedefineConfigfromvitest/config.ProvidedEnvaugmentation becameCloudflare.Env, and the test tsconfigs point at@cloudflare/vitest-pool-workers/types.test/setup.tsnowawait reset()inbeforeEach. This one is load-bearing: without it 28 tests fail on tables leaked from the previous test, so the isolation the suites assume is still genuinely enforced.Also:
check-generated-drift.tsusesBuffer.compareinstead of.equals, which workers-types v5's globalBufferno longer exposes; and bothworker-configuration.d.tsare regenerated with the new wrangler. Thewrangler.jsonccompatibility dates are untouched — those are deliberate pins.@types/nodeis pinned to the 24 line everywhere rather than the newest release. The fixtures were on 25, an EOL line, while CI pins Node 24 LTS. Happy to move the whole toolchain to Node 26 instead if you'd rather chase latest there.Deliberately left behind
moduleResolution: node10, and the native port doesn't expose the compiler API (transpileModule,ModuleKind,ScriptTarget) thattest/generator/evaluate.tsandscenarios.tscompile fixtures with.Neither resolves an advisory; both are worth their own change if wanted.
Verification
make verify-localfully green against a freshly built plugin: 80 unit + 27 candidate tests, generated-output drift clean under javy 9, 33 miniflare tests, 5 example tests.make fmt-checkclean. Regenerating the protobuf bindings with buf 1.72.0 produced no diff.