[stable-diffusion] Match diffusers Transformer2D GroupNorm epsilon - #1448
Open
saichowdary007 wants to merge 1 commit into
Open
saichowdary007 wants to merge 1 commit into
saichowdary007 wants to merge 1 commit into
Conversation
Fixes ml-explore#1434 Signed-off-by: sai <saikumar@sais-MacBook-Pro.local>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1434.
Transformer2Dis shared by the Stable Diffusion UNet, but its inputGroupNormrelied on MLX's defaulteps=1e-5. Diffusers' referenceTransformer2DModeluseseps=1e-6, and the mismatch accumulates through theUNet. Pass the reference epsilon explicitly while leaving the UNet ResNet and
LayerNorm defaults unchanged.
Testing
cd stable_diffusion && PYTHONPATH=. python -m unittest test_unet -vpre-commit run --files stable_diffusion/stable_diffusion/unet.py stable_diffusion/test_unet.pyThe regression test constructs a
Transformer2Dwithout downloading modelweights and asserts that its GroupNorm uses
1e-6.Implementation and test preparation used AI assistance; the submitting
contributor reviewed the changed lines and owns the behavior validation.