Conversation
Keep at least one prompt token available for first-token logits on exact cache hits. Trim trimmable caches by one token; for non-trimmable hybrid caches reuse the nearest prelast checkpoint or safely recompute.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When a client resends the exact same full prompt,
LRUPromptCache.fetch_nearest_cachereturns a legitimate exact hit with
rest=[]. The empty segment then reachesBatchGenerator.insert_segmentsand crashes the request (it needs at least oneprompt token to produce the first logits).
Fix
_generation_safe_cache_hitguarantees generation always has at least oneprompt token after a cache hit:
cache for
prompt[:-1]and replay the final tokenNon-exact-hit paths are unchanged.
Testing
tests/test_server_cache_exact.pycovers both cache kinds and the recomputefallback (11 cases).