Fix lm-eval continuation scoring after partial context truncation - #1902
Merged
michalk8 merged 1 commit intoSep 21, 2026
Merged
Conversation
michalk8
approved these changes
Sep 21, 2026
michalk8
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for spotting this!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes a scoring bug in the lm-eval adapter's
MLXLM.loglikelihood()method. Currently,MLXLM.loglikelihood()uses the truncated prefix length to slice untruncated full sequences. As a result, it incorrectly includes context tokens in continuation scoring after partial context truncation.For example, with a character tokenizer, context
abc, continuationde, andmax_tokens=3, the context becomesbc. The code should scorede, but it currently scorescdeinstead.The PR fixes the bug by saving the original continuation boundary before truncating the prefix. This keeps the scoring focused on the continuation. The existing truncation policy and fully truncated
(-inf, False)behavior stay the same.Testing
This PR adds a test covering no truncation and two partial-truncation cases. Both partial-truncation cases fail before the fix and pass afterward.