Minimal adoption of materialized-array from mlx-swift-lm - #488
Open
davidkoski wants to merge 1 commit into
Open
davidkoski wants to merge 1 commit into
davidkoski wants to merge 1 commit into
Conversation
davidkoski
commented
Jul 20, 2026
|
|
||
| // Generate response using the model | ||
| return try await modelContainer.perform { (context: ModelContext) in | ||
| return try await modelContainer.perform { context in |
Member
Author
There was a problem hiding this comment.
Not sure why the type was specified here -- just omit and it builds fine.
davidkoski
commented
Jul 20, 2026
Comment on lines
-199
to
+207
| _ context: inout ModelContext | ||
| _ context: inout TrainableModelContext | ||
| ) { | ||
| if let extraEosToken { | ||
| context.configuration.extraEOSTokens.insert(extraEosToken) | ||
| } | ||
| } | ||
|
|
||
| func generate( | ||
| input: LMInput, context: ModelContext | ||
| input: LMInput, context: ModelContextProviding |
Member
Author
There was a problem hiding this comment.
These are the two examples I use in ModelContainer for how to update.
This was referenced Jul 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Minimal adoption of materialized-array from mlx-swift-lm
See ml-explore/mlx-swift-lm#335
Checklist
Put an
xin the boxes that apply.pre-commit run --all-filesto format my code / installed pre-commit prior to committing changes