update documentation and skills - #489
Open
davidkoski wants to merge 1 commit into
Open
davidkoski wants to merge 1 commit into
davidkoski wants to merge 1 commit into
Conversation
- make sure we are using current best practices e.g. for #huggingFaceTokenizerLoader() - where found, update skills to current API
davidkoski
commented
Jul 31, 2026
Comment on lines
+13
to
+16
| let modelContainer = try await EmbedderModelFactory.shared.loadContainer( | ||
| from: #hubDownloader(), | ||
| using: #huggingFaceTokenizerLoader(), | ||
| configuration: EmbedderRegistry.nomic_text_v1_5 |
Member
Author
There was a problem hiding this comment.
Some stragglers using the old API
davidkoski
commented
Jul 31, 2026
| let texts = ["First text", "Second text", "Third text"] | ||
|
|
||
| let embeddings = await container.perform { model, tokenizer, pooler in | ||
| let embeddings = await container.perform { context in |
Member
Author
There was a problem hiding this comment.
Update this to the non-deprecated form of the call. Note that all of this will be obsolete with #335
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Checklist
Put an
xin the boxes that apply.pre-commit run --all-filesto format my code / installed pre-commit prior to committing changes