compile and vmap can produce Sendable closures from Sendable inputs - #469
Open
davidkoski wants to merge 4 commits into
Open
davidkoski wants to merge 4 commits into
davidkoski wants to merge 4 commits into
Conversation
- this idea comes from ml-explore/mlx-swift-lm#589 (@aleroot) - breaking change for compile calls that capture state without using inputs:
davidkoski
commented
Sep 3, 2026
| ) -> ( | ||
| [MLXArray] | ||
| ) -> MLXArray { | ||
| ) -> ([MLXArray]) -> MLXArray { |
Member
Author
There was a problem hiding this comment.
Cleaner formatting. I was going to change grad in the same way, but it typically needs a model and I am not sure I can pass that through the most-inner closure that this uses. Keep as not-Sendable.
5 tasks
This was referenced Sep 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Checklist
Put an
xin the boxes that apply.pre-commit run --all-filesto format my code / installed pre-commit prior to committing changes