Add countNonzero to the Swift API - #479
Merged
Merged
Conversation
Silenterc
commented
Sep 14, 2026
| XCTAssertEqual(r2, [Complex(-4, 24)]) | ||
| } | ||
|
|
||
| func testCountNonzero() { |
Contributor
Author
There was a problem hiding this comment.
Noticed that the Swift-wrapped ops arent really tested much, please let me know if adding these tests was unnecessary :)
Member
There was a problem hiding this comment.
Tests are good! See also #477
My logic was that beyond a certain point the swift tests weren't adding much -- the real code was mlx-side. However, when I updated the tests in 477 I found several gaps and bugs in the swift layer.
Silenterc
force-pushed
the
add-count-nonzero
branch
from
September 14, 2026 14:49
44af782 to
b9ff094
Compare
davidkoski
approved these changes
Sep 14, 2026
davidkoski
left a comment
davidkoski
left a comment
Member
There was a problem hiding this comment.
Change looks good, thank you!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
count_nonzero, so I added it as a free function and anMLXArraymethod + docsChecklist
Put an
xin the boxes that apply.pre-commit run --all-filesto format my code / installed pre-commit prior to committing changes