add thin logging shim - #484
Open
davidkoski wants to merge 3 commits into
Open
davidkoski wants to merge 3 commits into
davidkoski wants to merge 3 commits into
Conversation
nwh
approved these changes
Sep 16, 2026
nwh
left a comment
Collaborator
There was a problem hiding this comment.
Nice! The API is also similar to conventional Python logging. eg
import logging
logger = logging.getLogger(__name__)
def foo():
logger.info("foo was called")
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
See ml-explore/mlx-swift-lm#535 (comment)
mlx-swift and related sometimes (rarely) wants to log something. We never picked a solution, and I don't want to lock people in to any particular solution. This adds a very thin logging shim that looks similar to
swift-logand has a default OSLog/stderr implementation. Developers can integrate whatever they want and MLX code can now log things if needed.Checklist
Put an
xin the boxes that apply.pre-commit run --all-filesto format my code / installed pre-commit prior to committing changes