Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
I’m an ML engineer and researcher, a passionate Apple user. I’d like to contribute to MLX and develop a deeper understanding of its internals. I’m particularly excited about its potential for local inference and building LLMs end to end, from pretraining to post-training.
This pull request fixes #4460.
This adds
DEFINE_INPUT_OUTPUT_SHAPE()toScan, allowing it to infer the output shape from its input.Please note that I also noticed https://github.com/ml-explore/mlx/pull/4468/changes has a similar fix but was rejected due to use of AI. Please advise me on the best practices for this type of fixes if this fix does not meet your standards! Also, please let me know if there is any better starter bug/task for me. I am happy to help and learn more during the process!
Validation
Tested on my Apple silicon (M1 Max with 32G of unified memory) with macOS 26.6.2 and Python 3.12.10: