Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4503
Captured floating-point constants in compiled kernels are currently printed using
digits10 + 1digits. For some values this isn't enough precision to round-trip back to the same float which can make the compiled result slightly different from eager execution.Changed
print_float_constantto usemax_digits10instead. This gives enough precision for the value to round-trip correctly when the generated kernel source is compiled.Also added tests with float32 constants that were affected by this issue. This includes
1 / 3, 128**-0.5, and0.7071067811865476. I also updated the float64 test to usemath.nextafter(1.0, 2.0)so it catches the same issue for doubles. The tests usemx.array_equalto make sure the eager and compiled results match.