Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #4502
Bug
The symptom was that complex types with NaNs in their imaginary part are sorted differently on CPU and GPU:
The reason is in the CPU implementation of
sort.cpp, which usesstd::isnaninstead ofmlx::core::isnan.This is problematic because our
mlx::complextype has a castoperator() floatoperator which returns the real part.Therefore, using
std::isnanonly returns true if the real part is a NaN, but ignores the imaginary part, hence the bug.The GPU implementation did not suffer from this issue, e.g. Metal sort has explicit
isnanfor both partsFix
The fix was first to convert current
std::isnantomlx::core::isnanfor all arguments that could be either floating point types or complex.A better fix would be to make the operator
explicit, which would prevent silent cast the complex type tofloatbut that seems a larger impact.Verified that the fix works as expected:
std::isnanusage on possible complex args, and produced the tests.