Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Investigating the CI build failure I realized that : a CUDA error that MLX has already reported stays set on the calling thread, and
Event::wait()re reads it withcudaPeekAtLastError().After one failed allocation every later
evalon that thread throwscudaPeekAtLastError() failed: out of memory, even though nothing is wrong. When the read comes through the buffer protocol the exception escapes theextern "C"getbufferslot and the process aborts with exit 134.This is what took down the
Linux (cuda-*, x86_64)jobs after an OOM intest_fast_sdpa. see: #4522