Fix col_reduce_longcolumn for negative-stride views - #4529
Open
mateuuszzzzz wants to merge 2 commits into
Open
mateuuszzzzz wants to merge 2 commits into
mateuuszzzzz wants to merge 2 commits into
Conversation
mateuuszzzzz
marked this pull request as ready for review
September 17, 2026 22:28
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #4528
Details
The thread coordinate (
lid.x) incol_reduce_longcolumnis an unsigned integer and causes implicit conversion ofin_idxto an unsigned integer in the expressionin_idx + lid.x. This implicit conversion wraps the input offset for negative-stride views. PR fixes this by adding an explicit type cast oflid.xtoIdxT, ensuring both operands share the same signed type and avoiding the implicit conversion ofin_idx.Tests cover operations relying on reduce kernels and all dispatch paths for the
col_reduce*family.I verified that all test cases picking
col_reduce_longcolumnfail on main and pass after applying the fix.☑️ I understand it is strictly prohibited to use AI to write PR description
AI usage disclosure: Opus 5 assisted with:
sumare impacted by the bug (and pointed me tocol_reduce*family)col_reduce*kernelsI verified the exact reproduction conditions, implemented a fix, and ran local checks and tests before pushing.