fix(android): load v9 on old architecture (RNZA-5) - #385
Merged
Conversation
Hardcoding isTurboModule=true hid RNZipArchive from the legacy NativeModule registry on old-arch apps, so NativeModules.RNZipArchive was null. Follow BuildConfig.IS_NEW_ARCHITECTURE_ENABLED instead. Add playground-rn old-arch Maestro CI (RNZA-5) and document the compatibility matrix. Stay on v7 only for RN < 0.70. Co-authored-by: plrthink <plrthink@gmail.com>
RN's gradle plugin reads newArchEnabled from the file, so -PnewArchEnabled=false still produced IS_NEW_ARCHITECTURE_ENABLED=true and the old-arch Android e2e never actually ran old arch. iOS old-arch Maestro already passed. Co-authored-by: plrthink <plrthink@gmail.com>
RN 0.82+ ignores newArchEnabled=false and RCT_NEW_ARCH_ENABLED=0, so playground-rn (0.83) cannot opt out. Move old-arch CI to a throwaway 0.81.6 app (last opt-out line) and document the matrix. Co-authored-by: plrthink <plrthink@gmail.com>
Android 0.81 old-arch assemble already passed with IS_NEW_ARCHITECTURE_ENABLED=false. iOS pod install failed because RN 0.81 defaults to iOS 15.1 and RNZipArchive requires 15.5. Co-authored-by: plrthink <plrthink@gmail.com>
ls *.xcworkspace listed contents.xcworkspacedata inside the bundle. Use ls -d so xcodebuild gets RnzaOldArch.xcworkspace. Co-authored-by: plrthink <plrthink@gmail.com>
plrthink
marked this pull request as ready for review
September 4, 2026 18:16
v7 only for RN < 0.70. Latest v9 on 0.70–0.81 including old architecture (0.81 compile CI). New Architecture only on 0.82+. Stop treating New Architecture as required on 0.70–0.81. Co-authored-by: plrthink <plrthink@gmail.com>
plrthink
added a commit
that referenced
this pull request
Sep 5, 2026
Patch for the Android old-architecture NativeModule load fix and the RN-version install table (#385). Co-authored-by: Cursor Agent <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
isTurboModulefollowsBuildConfig.IS_NEW_ARCHITECTURE_ENABLED. HardcodingtruehidNativeModules.RNZipArchivewhen New Architecture was off (RN 0.70–0.81)..github/workflows/old-arch.ymlcompiles a throwaway RN 0.81.6 app with New Architecture off (last RN that can opt out). RN 0.82+ ignores the flags.^7.0.0only for RN < 0.70; latest v9 on 0.70–0.81 including old architecture; New Architecture only on 0.82+.Install decision
^7.0.0No Interop package. Same JS API.
Test plan
npm test(64) /npm run lintIS_NEW_ARCHITECTURE_ENABLED=false)e2e.yml)Squash on merge is fine — the branch has CI-iteration commits.