fix(api-client): add explicit extensions to relative imports#6609
Open
creeperkatze wants to merge 4 commits into
Open
fix(api-client): add explicit extensions to relative imports#6609creeperkatze wants to merge 4 commits into
creeperkatze wants to merge 4 commits into
Conversation
Member
Pull request changelogAppAddedChangedDeprecatedRemovedFixedSecurityWebsiteAddedChangedDeprecatedRemovedFixedSecurityHostingAddedChangedDeprecatedRemovedFixedSecurity |
Member
|
ideally this should be enforced by the linter, i imagine it's not currently right? |
Contributor
Author
I added a linting rule, though this plugin was required: https://www.npmjs.com/package/eslint-plugin-n |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The packages
.d.tsfiles re-export each other via extensionless relative specifiers. That works undermoduleResolution: bundler, but fails under Node's strict ESM resolution (nodenext), making namespaces likeLabrinthunresolvable for plain Node.js consumers.This PR adds explicit
.jsextensions to all relative imports, which works for both modes.