feat(manifest): report concrete shared provider alternatives - #5078
ScriptedAlchemy wants to merge 8 commits into
Conversation
🦋 Changeset detectedLatest commit: 964500c The changes in this PR will be included in the next version bump. This PR includes changesets to release 48 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
@module-federation/devtools
@module-federation/cli
create-module-federation
@module-federation/dts-plugin
@module-federation/enhanced
@module-federation/error-codes
@module-federation/esbuild
@module-federation/managers
@module-federation/manifest
@module-federation/metro
@module-federation/metro-plugin-rnc-cli
@module-federation/metro-plugin-rnef
@module-federation/metro-plugin-rock
@module-federation/modern-js
@module-federation/modern-js-v3
@module-federation/native-federation-tests
@module-federation/native-federation-typescript
@module-federation/nextjs-mf
@module-federation/node
@module-federation/observability-plugin
@module-federation/playground
@module-federation/retry-plugin
@module-federation/rsbuild-plugin
@module-federation/rspack
@module-federation/rspress-plugin
@module-federation/rstest
@module-federation/runtime
@module-federation/runtime-core
@module-federation/runtime-tools
@module-federation/sdk
@module-federation/storybook-addon
@module-federation/third-party-dts-extractor
@module-federation/treeshake-frontend
@module-federation/treeshake-server
@module-federation/typescript
@module-federation/utilities
@module-federation/webpack-bundler-runtime
@module-federation/bridge-react
@module-federation/bridge-react-webpack-plugin
@module-federation/bridge-shared
@module-federation/bridge-vue3
@module-federation/inject-external-runtime-core-plugin
commit: |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6a1e8102d9
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| (providerModule.identifier !== undefined && | ||
| reason.moduleIdentifier === providerModule.identifier) || | ||
| (providerModule.name !== undefined && | ||
| (reason.moduleName === providerModule.name || | ||
| reason.resolvedModule === providerModule.name)), |
There was a problem hiding this comment.
When webpack reports a re-exported or concatenated provider relationship only through reason.resolvedModuleIdentifier—for example, when the optional module names are absent or differ—this predicate never associates the resource module with its provider. The existing collectRelationshipMap logic in ModuleHandler.ts already uses resolvedModuleIdentifier for webpack, whereas this code checks only Rspack's moduleIdentifier; consequently the provider receives no entry and the alternatives array can be deleted as having fewer than two providers. Include resolvedModuleIdentifier in the identifier match.
Useful? React with 👍 / 👎.
…red-provider-metadata
|
The That merge regenerated Fixed on #5039 in To fix this branch, merge #5039's current head ( |
…red-provider-metadata
…red-provider-metadata
1 participant
Description
Add optional
providersmetadata when one shared identity has multiple concrete version/import pairs. For example, a build providing React 18 and React 19 now records each provider's import and assets instead of exposing only the existing shared row. Existing top-level fields remain unchanged; single-provider and consumer-only entries omit the new field. Alternatives stay within their scope/layer identity, and older readers remain supported.Related Issue
Stacked on layers PR #5039 (
feat/rspack-layered-shared-metadata), which builds on graph foundation #5080. Scalar scope selection is the separate sibling PR #5079.Types of changes
Checklist
Testing: affected dependency build (15 tasks); manifest (59), SDK (69 passed, one existing skip), shared/layer tests (330), config/cache integration (22). Real compiler fixtures check default/common layers, exact provider imports/assets, and singleton client-layer isolation. Foundation rollback/remote tests and legacy-reader compatibility pass. Normal commit hooks and repository formatting pass. Unrelated full-workspace/e2e suites were not rerun; public docs are unchanged, and a changeset is included.