Make proxy image configurable - #155
Merged
Merged
Conversation
gilberthl-mh
force-pushed
the
make-proxy-image-configurable
branch
2 times, most recently
from
May 5, 2026 13:17
6449ea6 to
ddc189a
Compare
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 00d81ec. Configure here.
…est coverage Allow overriding the built-in HTTP proxy image via NAVY_HTTP_PROXY_IMAGE or Navyfile httpProxyImage, and forward custom env via httpProxyEnv / NAVY_HTTP_PROXY_ENV. Fix navyFile propagation when toggling HTTPS or destroying one Navy while others remain. Modernise for Node 22: dependency updates, audit remediation, Flow/lint fixes. CI uses Moneyhub runners and routes dockerode through DOCKER_HOST so it matches docker compose. Integration tests updated for commander v12 and rimraf v5. Add c8 with 100% unit test coverage, CLI fixes (-e/--navy ordering, reject unknown subcommand options), and docs (http-proxy, navyfile-config, intent doc).
gilberthl-mh
force-pushed
the
make-proxy-image-configurable
branch
from
June 22, 2026 16:05
6d6649a to
e1191f7
Compare
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Medium Risk
Touches Docker proxy compose generation and HTTPS reconfiguration paths, but defaults preserve existing behavior; the large dependency, CI, and test surface increases merge and regression risk.
Overview
This PR makes the built-in HTTP reverse proxy configurable while keeping
navycloud/navy-proxyas the default. Operators can override the proxy image viaNAVY_HTTP_PROXY_IMAGEorhttpProxyImageinNavyfile.js(env wins), and forward runtime env into the proxy viahttpProxyEnv/NAVY_HTTP_PROXY_ENV(merged, with the allowlist overriding on collisions; noenvironment:block when unset).Proxy compose generation now uses helpers for image/env resolution and mounts the Docker socket from
DOCKER_HOSTwhen it is aunix://path so CI and local Docker setups stay aligned. The HTTPS CLI passesnavyFileintoreconfigureHTTPProxyso custom proxy settings are not dropped when toggling HTTPS.Alongside the feature, the repo moves to Node ≥22 (Babel target, engines, dependency refresh), adds
c8with strict coverage thresholds and a large unit-test backfill, tweaks Flow/ESLint (drops flowtype plugin, addsflow-libs/), and overhauls GitHub Actions (Node 22/24 matrix, pinned actions,docker/setup-docker-actionwithset-host: true, Compose setup). User docs and a branch intent note describe precedence and examples.Reviewed by Cursor Bugbot for commit e1191f7. Bugbot is set up for automated code reviews on this repo. Configure here.